Closed
Bug 1188457
Opened 6 years ago
Closed 6 years ago
Fix SapiService.cpp compilation on mingw.
Categories
(Core :: Web Speech, defect)
Core
Web Speech
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
2.11 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
The main problem is that sapi library (aka. sapi.lib or libsapi.a) providing sapi IIDs is not imported explicitly. It's not required on MSVC, because PSDK headers use #pragma for that, but it's not supported on mingw. Also, GCC errors on nullptr returned instead of bool and there are tons of warnings for not handled enum values in OnSpeechEvent.
Attachment #8639940 -
Flags: review?(jmathies)
![]() |
||
Comment 1•6 years ago
|
||
Comment on attachment 8639940 [details] [diff] [review] fix Review of attachment 8639940 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/library/moz.build @@ +357,5 @@ > 'wbemuuid', > 'wintrust', > 'wtsapi32', > + 'locationapi', > + 'sapi', nit - old code didn't have the trailing comma. not sure if wee have a rule about that in build files or not.
Attachment #8639940 -
Flags: review?(jmathies) → review+
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1c313117618
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•