1188508 - logviewer could use new getRevisionUrl filter

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[William Lachance (:wlach)]

In bug 1185155 :MikeLing added a new filter for linking to treeherder result sets. We could use this filter to somewhat simplify the link inside the logviewer:

You would modify the link here:

https://github.com/mozilla/treeherder/blob/master/ui/logviewer.html#L26

And remove the current calculation of the link here:

https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/logviewer.js#L207

Here's an example logviewer link to test:

http://localhost:8000/logviewer.html#?job_id=12207076&repo=mozilla-inbound

If you're interested in doing this, Mike, feel free to grab this bug. Otherwise we can probably find someone else to do it. :)

Comment 1

[MikeLing]

Attachment: PR for bug 1188508

Sorry, I somehow haven't see the notification of this bug and don't know you mention in it. However, make response so late, sorry about that :( 

Some links in comment 0 seems like outdate, but I think it's not a problem. Hope this PR can fit your mind. :)

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8649828 [details] [review]
PR for bug 1188508

Np, this looks like it's on the right track but needs some minor adjustment.

Comment 3

[MikeLing]

Comment on attachment 8649828 [details] [review]
PR for bug 1188508

Just address it, thank you for your advice :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d5a3f25ca230135b510379362de0658e8c946cf3
Bug 1188508 - logviewer could use new getRevisionUrl filter

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8649828 [details] [review]
PR for bug 1188508

Looks good now, thanks! Merged.