1188516 - Add support for wrapping tree cairo surfaces in a system cairo surface

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Andrew Comminos [:acomminos]]

There are several places in the GTK3 widget code where we require pulling out data from a tree cairo surface. Currently, this is accomplished by borrowing an XLib drawable or locking in-memory bits.

We could reduce code duplication by providing a straightforward translation mechanism to get a system cairo_surface_t out of a Cairo DrawTarget or SourceSurface.

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Add BorrowedCairoSurface for retrieving a system cairo surface from a tree cairo surface.

This adds BorrowedCairoSurface with support for the image and XLib backends.

Comment 2

[Andrew Comminos [:acomminos]]

Attachment: Use BorrowedCairoSurface for widget drawing on GTK3.

This changes DrawThemeWithCairo to use BorrowedCairoSurface.

I'll write a patch for the drag and drop pixmap once it lands.

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8639987 [details] [diff] [review]
Add BorrowedCairoSurface for retrieving a system cairo surface from a tree cairo surface.

No more X!

Comment 4

[Andrew Comminos [:acomminos]]

Not much point in improving QoL for an unsupported backend; closing :)