1188609 - Remove mirroring support from RokuApp

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: remove-roku-mirror v0.1

We do not really support mirroring to Roku devices. The code is blocking other TCPSocket work.

I am breaking this into three patches:
1. Removes code from RokuApp.jsm
2. Removes support code from Fennec
3. Remove basic code from Firefox Desktop

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: remove-mobile-roku-mirror v0.1

This patch removes just the parts of the RokuDevice that affect mirroring. I also remove a special case preference.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: remove-desktop-roku-mirror v0.1

This removes the mirror-ability of Roku in the Desktop code. This patch does not remove all the code to allow tab mirroring on Desktop, but since Roku was the only candidate for Tab Mirroring to a device, maybe someone could file a new bug to remove the rest.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8640120 [details] [diff] [review]
remove-mobile-roku-mirror v0.1

Review of attachment 8640120 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/CastingApps.js
@@ -15,5 @@
>    factory: function(aService) {
>      Cu.import("resource://gre/modules/RokuApp.jsm");
>      return new RokuApp(aService);
>    },
> -  mirror: Services.prefs.getBoolPref("browser.mirroring.enabled.roku"),

I'm not really familiar with this code, but what Roku support do we have besides mirroring? Just trying to make sure there aren't more things we should remove...

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #3)

> I'm not really familiar with this code, but what Roku support do we have
> besides mirroring? Just trying to make sure there aren't more things we
> should remove...

We also support tab mirroring to Chromecast. We support video flinging to Roku, Chromecast and Matchstick right now. We have patches to support video flinging to other hardware too.

We might end up removing tab mirroring completely, but that is a different discussion and bug.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8640128 [details] [diff] [review]
remove-desktop-roku-mirror v0.1

Review of attachment 8640128 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2e5739c2d44c
https://hg.mozilla.org/integration/fx-team/rev/a9d0a5557f5c
https://hg.mozilla.org/integration/fx-team/rev/885afc6842b1

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2e5739c2d44c
https://hg.mozilla.org/mozilla-central/rev/a9d0a5557f5c
https://hg.mozilla.org/mozilla-central/rev/885afc6842b1