Closed Bug 1188614 Opened 9 years ago Closed 8 years ago

Rule view properties become unselectable and behave oddly when there are two in the same rule

Categories

(DevTools :: Inspector: Rules, defect, P2)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(firefox42 affected)

Status:
RESOLVED DUPLICATE of bug 1069829
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: bgrins, Assigned: tromey)

Details

(Whiteboard: [rule-view-correctness]) 

* Open this page: data:text/html,<body></body>
* Open the Inspector and select the body element
* Add these two properties:
    margin-left: 10px;
    margin: 5px;
* Uncheck margin-left
* Try to recheck it

Expected: it becomes checked
Actual: it doesn't become checked

Maybe this will be resolved by the authored styles work, needs some investigation to see what's causing the bug
Another related STR:

data:text/html,<style> body {background: orange !important}</style><body style="background:red"></body>

Select the <body> element
Add a 'background: blue' in the 'element' style area
Uncheck the blue
Try to recheck the blue

Notice that the red rule above turns to blue and that you can't recheck the blue property
Summary: Newly added rule view properties become unselectable and behave oddly when there are two of the same name and overridden → Rule view properties become unselectable and behave oddly when there are two in the same rule
(In reply to Brian Grinstead [:bgrins] from comment #0)

> Maybe this will be resolved by the authored styles work, needs some
> investigation to see what's causing the bug

I was planning to fix bug 913661 for as-authored, which seems similar to this.
So, taking it.
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
FWIW the example in comment #1 is still failing, even with as-authored,
probably because the sheet in question is the phony element sheet, which
isn't edited in the "authored" way.  So, that will require a bit more work.
Inspector bug triage. Filter on CLIMBING SHOES.
Property can not be checked, and rules are modified without any user input -> P2.

Tom: Triage ping :) Are you still planning to work on this? I assume the as-authored bug was Bug 984880 which has now landed. Any other blocker for this one?
Flags: needinfo?(ttromey)
Priority: -- → P2
Component: Developer Tools: Inspector → Developer Tools: CSS Rules Inspector
I fixed this (without realizing it) in bug 1069829. Element styles rules are now handled "as authored", like other rules.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(ttromey)
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.