1188620 - Use PersistentRooted for some misc JSObjects in markRuntime

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: use_persistent_rooted_for_async_activation-v0.diff

Now that PersistentRooted can root any object subclass and not just JSObject exactly, we can have it do the heavy lifting of rooting the SavedFrame pointer in JSRuntime.

Comment 1

[:Paolo Amadini]

Comment on attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

That's cool! Redirecting final review to Nick who is a peer of the JS module.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

Review of attachment 8640142 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6dea3334b6c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6dea3334b6c

Comment 5

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e601c8a36227

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

Reopened due to backout in comment #5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/e601c8a36227

This will be in tomorrow's (7-Aug) nightly. Note that there's a nightly respin in progress now that will *NOT* contain these backouts.

Comment 8

[Terrence Cole [:terrence]]

This was not related to the crash, relanding.

Comment 9

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/17bfcce2b7d0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/17bfcce2b7d0