Closed Bug 1188620 Opened 4 years ago Closed 4 years ago

Use PersistentRooted for some misc JSObjects in markRuntime

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

Now that PersistentRooted can root any object subclass and not just JSObject exactly, we can have it do the heavy lifting of rooting the SavedFrame pointer in JSRuntime.
Attachment #8640142 - Flags: review?(paolo.mozmail)
Comment on attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

That's cool! Redirecting final review to Nick who is a peer of the JS module.
Attachment #8640142 - Flags: review?(paolo.mozmail) → review?(nfitzgerald)
Comment on attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

Review of attachment 8640142 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8640142 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/d6dea3334b6c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Reopened due to backout in comment #5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla42 → ---
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/e601c8a36227

This will be in tomorrow's (7-Aug) nightly. Note that there's a nightly respin in progress now that will *NOT* contain these backouts.
This was not related to the crash, relanding.
https://hg.mozilla.org/mozilla-central/rev/17bfcce2b7d0
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.