Use PersistentRooted for some misc JSObjects in markRuntime

RESOLVED FIXED in Firefox 43

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

Now that PersistentRooted can root any object subclass and not just JSObject exactly, we can have it do the heavy lifting of rooting the SavedFrame pointer in JSRuntime.
Attachment #8640142 - Flags: review?(paolo.mozmail)

Comment 1

3 years ago
Comment on attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

That's cool! Redirecting final review to Nick who is a peer of the JS module.
Attachment #8640142 - Flags: review?(paolo.mozmail) → review?(nfitzgerald)
Comment on attachment 8640142 [details] [diff] [review]
use_persistent_rooted_for_async_activation-v0.diff

Review of attachment 8640142 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8640142 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/d6dea3334b6c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Reopened due to backout in comment #5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

3 years ago
status-firefox42: fixed → ---
Target Milestone: mozilla42 → ---
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/e601c8a36227

This will be in tomorrow's (7-Aug) nightly. Note that there's a nightly respin in progress now that will *NOT* contain these backouts.
(Assignee)

Comment 8

3 years ago
This was not related to the crash, relanding.
https://hg.mozilla.org/mozilla-central/rev/17bfcce2b7d0
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.