Closed Bug 1188650 Opened 4 years ago Closed 4 years ago

Rename LIR-Common.h to shared/LIR-shared.h

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: sstangl, Assigned: sstangl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This change fits the naming convention followed by the other files.
Attachment #8640188 - Flags: review?(nicolas.b.pierron)
Assignee: nobody → sstangl
Oops, clicked wrong patch.
Attachment #8640188 - Attachment is obsolete: true
Attachment #8640188 - Flags: review?(nicolas.b.pierron)
Attachment #8640192 - Flags: review?(nicolas.b.pierron)
Probably this should also move LOpcodes.h to shared/LOpcodes-shared.h. Does that sound OK to you?
Comment on attachment 8640192 [details] [diff] [review]
0001-Rename-LIR-Common.h-to-shared-LIR-shared.h.patch

Review of attachment 8640192 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)
Attachment #8640192 - Flags: review?(nicolas.b.pierron) → review+
(In reply to Sean Stangl [:sstangl] from comment #2)
> Probably this should also move LOpcodes.h to shared/LOpcodes-shared.h. Does
> that sound OK to you?

I will just notice that we usually have a jit/*.h file which dispatch the include based on the CodeGen, and then each architecture file includes the shared file.  So, if we were to do it properly, I feel that we would have to split the file in 2, one LOpcodes.h, which includes all, and one LOpcode-shared.h, which defines the shared list of LIR opcodes.

I do not have a strong opinion, so feel free to do it if you think this is the right approach.
https://hg.mozilla.org/mozilla-central/rev/ada67c4f187d
https://hg.mozilla.org/mozilla-central/rev/7b2a1ef36fcb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.