1188650 - Rename LIR-Common.h to shared/LIR-shared.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Move-Lowering-s-visitConstant-to-shared-code.-r.patch

This change fits the naming convention followed by the other files.

Comment 1

[Sean Stangl [:sstangl]]

Attachment: 0001-Rename-LIR-Common.h-to-shared-LIR-shared.h.patch

Oops, clicked wrong patch.

Comment 2

[Sean Stangl [:sstangl]]

Probably this should also move LOpcodes.h to shared/LOpcodes-shared.h. Does that sound OK to you?

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8640192 [details] [diff] [review]
0001-Rename-LIR-Common.h-to-shared-LIR-shared.h.patch

Review of attachment 8640192 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

Comment 4

[Nicolas B. Pierron [:nbp]]

(In reply to Sean Stangl [:sstangl] from comment #2)
> Probably this should also move LOpcodes.h to shared/LOpcodes-shared.h. Does
> that sound OK to you?

I will just notice that we usually have a jit/*.h file which dispatch the include based on the CodeGen, and then each architecture file includes the shared file.  So, if we were to do it properly, I feel that we would have to split the file in 2, one LOpcodes.h, which includes all, and one LOpcode-shared.h, which defines the shared list of LIR opcodes.

I do not have a strong opinion, so feel free to do it if you think this is the right approach.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ada67c4f187d
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b2a1ef36fcb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ada67c4f187d
https://hg.mozilla.org/mozilla-central/rev/7b2a1ef36fcb