Closed Bug 1188687 Opened 10 years ago Closed 10 years ago

Speed up the validator

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2015-08

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: [validator-phase-1][qa-])

Validator timeouts are currently far too common. Profiler results show a lot effective low hanging fruit optimizations we can make. So, let's make them.
Commits pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/c12e86445f70c22c89d5a46575f8ba99d2c8a186 Bug 1188687: Part 1 - Use a single running instance of the Spidermonkey shell per validation run. https://github.com/mozilla/amo-validator/commit/024bd4279fb60a5a80f1271a70bb979a7d5d4bba Bug 1188687: Part 2 - Remove, rework, or replace slow charset conversion code. https://github.com/mozilla/amo-validator/commit/4038795f02fb7bbf3449f3ac5b6b8fe4aa32b037 Bug 1188687: Part 3 - Miscellaneous optimizations based on profile data.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-08
Do we have any specific steps for this?
Flags: needinfo?(kmaglione+bmo)
Going to mark this as qa- for now. In the future, we should come up with some sort of benchmarking procedure.
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [validator-phase-1] → [validator-phase-1][qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.