Speed up the validator

RESOLVED FIXED in 2015-08

Status

addons.mozilla.org Graveyard
Add-on Validation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks: 1 bug)

unspecified
2015-08

Details

(Whiteboard: [validator-phase-1][qa-])

Validator timeouts are currently far too common. Profiler results show a lot effective low hanging fruit optimizations we can make. So, let's make them.
https://github.com/mozilla/amo-validator/pull/310

Comment 2

2 years ago
Commits pushed to master at https://github.com/mozilla/amo-validator

https://github.com/mozilla/amo-validator/commit/c12e86445f70c22c89d5a46575f8ba99d2c8a186
Bug 1188687: Part 1 - Use a single running instance of the Spidermonkey shell per validation run.

https://github.com/mozilla/amo-validator/commit/024bd4279fb60a5a80f1271a70bb979a7d5d4bba
Bug 1188687: Part 2 - Remove, rework, or replace slow charset conversion code.

https://github.com/mozilla/amo-validator/commit/4038795f02fb7bbf3449f3ac5b6b8fe4aa32b037
Bug 1188687: Part 3 - Miscellaneous optimizations based on profile data.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-08

Comment 3

2 years ago
Do we have any specific steps for this?
Flags: needinfo?(kmaglione+bmo)
Going to mark this as qa- for now. In the future, we should come up with some sort of benchmarking procedure.
Flags: needinfo?(kmaglione+bmo)
Whiteboard: [validator-phase-1] → [validator-phase-1][qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.