1188703 - Rocketbar scroll behavior is backwards

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

STR:
- Open Browser
- Navigate to any webpage which scrolls.
- Scroll down.

Expected Result:
The rocketbar will collapse as you scroll down.

Actual Result:
The rocketbar collapses, then abruptly expands.

As a bonus, when you scroll the other direction the rocketbar collapses. So basically the gesture is reversed!

Comment 1

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: This should block as basic browser functionality is broken.

Comment 2

[Kevin Grandon :kgrandon]

I was lucky enough to have a short regression window here, so I did a bisection:

git bisect start
# bad: [4b1b185afde3bc3bebf3467ef9e257adc46fc58e] Merge pull request #31121 from zbraniecki/1188162-long-month-on-lockscreen
git bisect bad 4b1b185afde3bc3bebf3467ef9e257adc46fc58e
# good: [1033b98696bef464bc6f0989b04bb9e3c5c40625] Bug 1170640 - Part 2: Fix linter bustage. r=BUSTAGE
git bisect good 1033b98696bef464bc6f0989b04bb9e3c5c40625
# good: [62955148918d5ca2d2d020c769411c22caf008b1] Merge pull request #31039 from albertopq/1185010-shb-ut
git bisect good 62955148918d5ca2d2d020c769411c22caf008b1
# good: [98191d8c0b83b6cbb9685811f532b20a2e072750] Merge pull request #29843 from rsajdok/bug#917045
git bisect good 98191d8c0b83b6cbb9685811f532b20a2e072750
# good: [ba33139c251108308cf882c152d9a7fff001bb83] Merge pull request #31129 from mozilla-b2g/bug-1183710
git bisect good ba33139c251108308cf882c152d9a7fff001bb83
# bad: [c33abac6292817011d3f1973496df0cbcb40fe2d] Bug 1188585 - Set maxBuffer when calling exec. r=gaye
git bisect bad c33abac6292817011d3f1973496df0cbcb40fe2d
# bad: [3a14891fb02627fe9a39f11b8dfa6aeca9d9ee91] Merge pull request #31025 from albertopq/1168948-pinning-preview-card2
git bisect bad 3a14891fb02627fe9a39f11b8dfa6aeca9d9ee91
# good: [862f0895f3f5a97200601542d99a152a46385a0b] Merge pull request #31116 from borjasalguero/window_open
git bisect good 862f0895f3f5a97200601542d99a152a46385a0b
# bad: [6f1656fda1ef6187a0298fe968448542f33245c3] Bug 1168948 - Adding preview card r=benfrancis
git bisect bad 6f1656fda1ef6187a0298fe968448542f33245c3
# first bad commit: [6f1656fda1ef6187a0298fe968448542f33245c3] Bug 1168948 - Adding preview card r=benfrancis

Likely caused by bug 1168948.

Comment 3

[Kevin Grandon :kgrandon]

Backed out bug 1168948 to fix this.