1188718 - Don't change the currently selected tab when clicking on the audio mute button

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Comment 1

[(no longer active)]

Attachment: Don't change the currently selected tab when clicking on the audio mute button

shorlander asked me to do this on IRC a week ago or so, I think.  This is a simple addition on top of bug 486262.

Comment 2

[(no longer active)]

Attachment: Don't change the currently selected tab when clicking on the audio mute button

I realized that the test didn't cover clicking on the mute icon on inactive pinned tabs...  This extends the test to cover that as well.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8640531 [details] [diff] [review]
Don't change the currently selected tab when clicking on the audio mute button

Review of attachment 8640531 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_audioTabIcon.js
@@ +42,5 @@
> +  yield hover_icon(icon, tooltip);
> +
> +  is(tooltip.getAttribute("label"), expectedTooltip, "Correct tooltip expected");
> +
> +  leave_icon(icon);

nit, can you remove the blank lines between these? (same for the changes below)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1878dfd5a193

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1878dfd5a193

Comment 6

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150818004007).