Closed Bug 1188718 Opened 4 years ago Closed 4 years ago

Don't change the currently selected tab when clicking on the audio mute button

Categories

(Firefox :: Tabbed Browser, defect)

42 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox41 --- unaffected
firefox42 --- verified

People

(Reporter: Ehsan, Assigned: Ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
shorlander asked me to do this on IRC a week ago or so, I think.  This is a simple addition on top of bug 486262.
Attachment #8640285 - Flags: review?(jaws)
Depends on: 486262
I realized that the test didn't cover clicking on the mute icon on inactive pinned tabs...  This extends the test to cover that as well.
Attachment #8640285 - Attachment is obsolete: true
Attachment #8640285 - Flags: review?(jaws)
Attachment #8640531 - Flags: review?(jaws)
Comment on attachment 8640531 [details] [diff] [review]
Don't change the currently selected tab when clicking on the audio mute button

Review of attachment 8640531 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_audioTabIcon.js
@@ +42,5 @@
> +  yield hover_icon(icon, tooltip);
> +
> +  is(tooltip.getAttribute("label"), expectedTooltip, "Correct tooltip expected");
> +
> +  leave_icon(icon);

nit, can you remove the blank lines between these? (same for the changes below)
Attachment #8640531 - Flags: review?(jaws) → review+
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/1878dfd5a193
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150818004007).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.