118876 - XML Parser error when printing a card that contains a < & or >

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Ninoschka Baca]

Overview: Problems printing cards that include some special characters such as 
"<" and "&".

Steps to reproduce:
1. Create a card with a special character. I entered the special charcter in the 
Last Name text box and also tried the email address (< or &).
2. File|Print Card

Actual Results: Prints an XML Parser error

Expected Results: Should print the card without xml error

Comment 1

[Ninoschka Baca]

Marking nsbeta1, xml parser errors should not appear for any character 
especially including "<" or "&".

Comment 2

[(not reading, please use [e-mail] instead)]

taking, I'm working on the fix.

Comment 3

[(not reading, please use [e-mail] instead)]

< & or > are the only characters that we need to escape.

this is the biggest ab printing wart, trying to compound-W it now.

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: first draft of a patch, still need to test.

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: better patch, creates less instances of the converter.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: even better fix (still need to test and build) that defines a contract id, removes the static cids, and adds a new constant for just html entity conversion.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: complete patch.

I'll seek a review from bienvenu and mscott.  I'm a little concerned that this
is over XPCOM-ification.  most people just choose to re-write this code when
they need it, since it isn't that much code.  see
rdf_EscapeAmpersandsAndAngleBrackets() in nsRDFXMLSerializer.cpp

but addressbook printing isn't a performance issue, and going through XPCOM
once per card to get the conv instance isn't that big of a deal.

Comment 8

[David :Bienvenu]

Comment on attachment 64105 [details] [diff] [review]
complete patch.

r=bienvenu, looks good - I was hoping to change ScanTxt to take 8 bit chars,
but apparently ScanTxt is perfect the way it is and can't be changed at all, so
this should be OK. I might end up adding 8 bit interfaces to scan txt and just
duplicate the code.

Comment 9

[Scott MacGregor]

Comment on attachment 64105 [details] [diff] [review]
complete patch.

sr=mscott

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

Comment 11

[Ninoschka Baca]

Trunk build 2002-02-01-03: WinMe, ok.
will check linux and mac next.

Comment 12

[Ninoschka Baca]

Trunk build 2002-03-01: Linux RH 7.1, Mac 9.1
Verified Fixed.