Closed
Bug 1188762
Opened 9 years ago
Closed 9 years ago
Use mozSystemWindowChromeEvent to instead of mozChromeEvent to send system-audiochannel-state-changed event
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Firefox OS Graveyard
AudioChannel
Tracking
(firefox42 fixed)
RESOLVED
FIXED
FxOS-S4 (07Aug)
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: evanxd, Assigned: evanxd)
References
Details
Attachments
(1 file)
|
1.13 KB,
patch
|
alwu
:
review+
|
Details | Diff | Splinter Review |
Use mozSystemWindowChromeEvent to instead of mozChromeEvent to send system-audiochannel-state-changed event.
|
||
Comment 1•9 years ago
|
||
Wrong bug component?
|
Assignee | |
Updated•9 years ago
|
Component: DMD → AudioChannel
Product: Core → Firefox OS
|
|
Assignee | |
Comment 2•9 years ago
|
||
Nicholas, thanks.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Hi Alastor, Could you help to review the patch and push the try. Thanks.
Attachment #8640344 -
Flags: review?(alwu)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8640344 [details] [diff] [review] bug-1188762.patch Review of attachment 8640344 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks! Here is the try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f601205ffe5
Attachment #8640344 -
Flags: review?(alwu) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3595d5849dfc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•