Closed Bug 1188780 Opened 5 years ago Closed 5 years ago

Include debug symbols in gtk3 tooltool package

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox42 affected)

RESOLVED FIXED
Tracking Status
firefox42 --- affected

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

For fine-grained suppressions on valgrind jobs, we're going to require debug symbols for gtk3 and related libraries from the tooltool package. Fortunately, that's not huge, that just makes the archives about 12M.

While doing this, I might as well add a local.conf for fontconfig (added in-tree in bug 1187245), and deal with bug 1188571 at the same time (in which case bug 1188571 can become the tooltool part assuming we go with that solution)
Assignee: nobody → mh+mozilla
Attachment #8640897 - Flags: review?(mshal)
Comment on attachment 8640897 [details] [diff] [review]
Include debug symbols in gtk3 tooltool package

>+chmod +x $root_dir/gtk3/setup.sh

Do you rely on the executable bit for setup.sh to run automatically from tooltool? If so, will that cause problems if we use a setup.sh script like this on a future package in Windows?
Attachment #8640897 - Flags: review?(mshal) → review+
tooltool's execute uses shell=True, so this should work on windows, but that would be a comment for bug 1188571.
https://hg.mozilla.org/mozilla-central/rev/2238409de271
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
url:        https://hg.mozilla.org/comm-central/rev/cfeeb77f8042b1466c224d8193b84c61aa9f80e0
changeset:  cfeeb77f8042b1466c224d8193b84c61aa9f80e0
user:       aleth <aleth@instantbird.org>
date:       Sun Aug 02 00:56:11 2015 +0200
description:
Keep mail/config/tooltool-manifests in sync (changes from Bug 1188780). rs=bustage-fix a=CLOSED TREE
had to back this out again for causing Bug 1190180 / Bug 1190317 or depend on
the backout of https://hg.mozilla.org/mozilla-central/rev/d093c57c6835
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Flags: needinfo?(mh+mozilla)
https://hg.mozilla.org/mozilla-central/rev/a9d3df6e14e0
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Backed out for causing bug 1190860.
https://hg.mozilla.org/mozilla-central/rev/54a3cfc16a11
Status: RESOLVED → REOPENED
Depends on: 1190860
Resolution: FIXED → ---
Target Milestone: mozilla42 → ---
Bug 1188780: Include debug symbols in gtk3 tooltool package. r?glandium

Re-landing of http://hg.mozilla.org/mozilla-central/rev/a9d3df6e14e0 with
'"setup": "setup.sh"' removed from all manifests.
Attachment #8643277 - Flags: review?(mh+mozilla)
Comment on attachment 8643277 [details]
MozReview Request: Bug 1188780: Include debug symbols in gtk3 tooltool package. r?glandium

Landed in two patches (one reverting the backout, one removing setup.sh invocations):

https://hg.mozilla.org/mozilla-central/rev/f8fbff4fd443
https://hg.mozilla.org/mozilla-central/rev/f3b757156f69
Attachment #8643277 - Flags: review?(mh+mozilla)
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Attachment #8643277 - Attachment is obsolete: true
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.