1188780 - Include debug symbols in gtk3 tooltool package

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For fine-grained suppressions on valgrind jobs, we're going to require debug symbols for gtk3 and related libraries from the tooltool package. Fortunately, that's not huge, that just makes the archives about 12M.

While doing this, I might as well add a local.conf for fontconfig (added in-tree in bug 1187245), and deal with bug 1188571 at the same time (in which case bug 1188571 can become the tooltool part assuming we go with that solution)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Include debug symbols in gtk3 tooltool package

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8640897 [details] [diff] [review]
Include debug symbols in gtk3 tooltool package

>+chmod +x $root_dir/gtk3/setup.sh

Do you rely on the executable bit for setup.sh to run automatically from tooltool? If so, will that cause problems if we use a setup.sh script like this on a future package in Windows?

Comment 3

[Mike Hommey [:glandium]]

tooltool's execute uses shell=True, so this should work on windows, but that would be a comment for bug 1188571.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2238409de271

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2238409de271

Comment 6

[aleth [:aleth]]

url:        https://hg.mozilla.org/comm-central/rev/cfeeb77f8042b1466c224d8193b84c61aa9f80e0
changeset:  cfeeb77f8042b1466c224d8193b84c61aa9f80e0
user:       aleth <[e-mail]>
date:       Sun Aug 02 00:56:11 2015 +0200
description:
Keep mail/config/tooltool-manifests in sync (changes from Bug 1188780). rs=bustage-fix a=CLOSED TREE

Comment 7

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/a6e767e90ee4

Comment 8

[Carsten Book [:Tomcat]]

had to back this out again for causing Bug 1190180 / Bug 1190317 or depend on
the backout of https://hg.mozilla.org/mozilla-central/rev/d093c57c6835

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9d3df6e14e0

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9d3df6e14e0

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing bug 1190860.
https://hg.mozilla.org/mozilla-central/rev/54a3cfc16a11

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1188780: Include debug symbols in gtk3 tooltool package. r?glandium

Bug 1188780: Include debug symbols in gtk3 tooltool package. r?glandium

Re-landing of http://hg.mozilla.org/mozilla-central/rev/a9d3df6e14e0 with
'"setup": "setup.sh"' removed from all manifests.

Comment 13

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/f8fbff4fd443
https://hg.mozilla.org/mozilla-central/rev/f3b757156f69

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8643277 [details]
MozReview Request: Bug 1188780: Include debug symbols in gtk3 tooltool package. r?glandium

Landed in two patches (one reverting the backout, one removing setup.sh invocations):

https://hg.mozilla.org/mozilla-central/rev/f8fbff4fd443
https://hg.mozilla.org/mozilla-central/rev/f3b757156f69