Closed Bug 1188794 Opened 9 years ago Closed 4 years ago

Different name property used for actor registration and removal

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected)

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: jwkbugzilla, Unassigned)

Details

The inline documentation on the DebuggerServer.removeGlobalActor() parameter currently says:

> Same object being given to related addGlobalActor call.

Generally, this isn't really true. When a new actor is registered the expected properties of the aActor parameter are constructorFun/id and constructorName. The latter becomes the name of the actor. When an actor is removed on the other hand, DebuggerServer.removeGlobalActor() expects an aActor.name property which is the same as aActor.constructorName of the registered actor.

I can only assume that the built-in actors always have both a constructorName and a name property and both are always equal. However, the API is currently inconsistent.
Product: Firefox → DevTools

I don't think this is relevant anymore.

Honza

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.