[System] Implement alwaysLowered window.open() feature in Gaia

RESOLVED FIXED in Firefox 42

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: salva, Assigned: salva)

Tracking

unspecified
FxOS-S5 (21Aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment on attachment 8640410 [details] [review]
[gaia] lodr:bug-1188797-always-lowered > mozilla-b2g:master

I don't know who is in charge of window management, Alberto, do you mind to redirect to the person in charge, please?
Attachment #8640410 - Flags: feedback?(apastor)
Comment on attachment 8640410 [details] [review]
[gaia] lodr:bug-1188797-always-lowered > mozilla-b2g:master

Probably Etienne is the right person to review this. Thanks!
Attachment #8640410 - Flags: feedback?(apastor) → review?(etienne)
Attachment #8640410 - Flags: review?(etienne) → feedback?(etienne)
This will be an alternative until we can perform openWindow from service workers.

So different documents don't have to include the same iframe to perform calls to a window that provides services, but all of them can share this hidden window.
(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #5)
> This will be an alternative until we can perform openWindow from service
> workers.
> 
> So different documents don't have to include the same iframe to perform
> calls to a window that provides services, but all of them can share this
> hidden window.

Tell me more.
Because a window opened with the feature from this patch will still be visible in the TaskManager and while edge swiping. So it might not fulfill the use-case.
Comment on attachment 8640410 [details] [review]
[gaia] lodr:bug-1188797-always-lowered > mozilla-b2g:master

This looks okay, we might add some permission check since we don't have popup blockers on FxOS and some tests of course :)

But let's wait and see if this really gives us what we want.
Attachment #8640410 - Flags: feedback?(etienne)
Attachment #8640411 - Attachment is obsolete: true
Attachment #8640410 - Attachment is obsolete: true
Comment on attachment 8643001 [details] [review]
[gaia] arcturus:bug-1188797 > mozilla-b2g:master

Made a few comments on github, I think it's worth doing another quick review round after that.
Attachment #8643001 - Flags: review?(etienne)
Comment on attachment 8643001 [details] [review]
[gaia] arcturus:bug-1188797 > mozilla-b2g:master

2nd review request
Attachment #8643001 - Flags: review?(etienne)
Comment on attachment 8643001 [details] [review]
[gaia] arcturus:bug-1188797 > mozilla-b2g:master

Cool, r=me with a small test added to app_transition_controller_test.js, something like
`  test('Do not focus an alwaysLowered window', function() {`
Attachment #8643001 - Flags: review?(etienne) → review+
Attachment #8643005 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/bee58bfd8bcf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
You need to log in before you can comment on or make changes to this bug.