1188927 - Register Firefox for Android as a handler for SVG files

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Will Pittenger]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:25.6) Gecko/20150723 Firefox/31.9 PaleMoon/25.6.0
Build ID: 20150723184543

Steps to reproduce:

I use ES File Explorer.  I have both Firefox 38 and Firefox Beta 40.  But when I try to open a SVG file from ES, it doesn't have a way to open it.  It would appear neither version of Firefox is registered as able to open SVG files in Android.

You might want to check all the supported file types.


Actual results:

Firefox doesn't appear to be able to open local SVG files from a file browser.


Expected results:

File browsers should be able to use Firefox to open SVG files.

Comment 1

[Pawel Golinski [:qiubit]]

Attachment: bug1188927_svg.diff

If I'm correct (I'm not sure if that's all that has to be done, but on my phone it works), these two lines added in AndroidManifest do the trick.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8641748 [details] [diff] [review]
bug1188927_svg.diff

LGTM, but I want Mike to double check this change.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8641748 [details] [diff] [review]
bug1188927_svg.diff

Review of attachment 8641748 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

I haven't done much digging into how we handle opening Intents but because nothing has changed, I'd expect this to just work.

Comment 4

[Jan Henning [:JanH]]

Seems like we forgot to actually check this in...

Comment 5

[Jan Henning [:JanH]]

The patch works with ES File Explorer, but not for the internal file manager on Android M, so this needs a little more investigation.

Comment 6

[Jan Henning [:JanH]]

... which is basically bug 1406903, as ES File Explorer uses file://, while the internal file manager uses content://

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4946d9cb418
Register Firefox for Android as a handler for SVG files. r=mcomella

Comment 8

[Jan Henning [:JanH]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4946d9cb4180e809ccc5587d97caf318e67e818
Bug 1188927 - Register Firefox for Android as a handler for SVG files. r=mcomella

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f4946d9cb418