Closed Bug 1188936 Opened 6 years ago Closed 6 years ago

Release/protect arenas sooner in compacting GC

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Although compacting GC is incremental, we currently wait till the end before we release or protect and arenas we reclaimed (protection is to catch stray accessed by the mutator to things it should no longer have pointers to).  It would be better to do this when we have finished compacting a zone.
Attachment #8640552 - Flags: review?(terrence)
Comment on attachment 8640552 [details] [diff] [review]
release-relocated-arenas-earlier

Review of attachment 8640552 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +2087,5 @@
> +static inline bool
> +ShouldProtectRelocatedArenas(JS::gcreason::Reason reason)
> +{
> +    // For zeal mode collections we don't release the relocated arenas
> +    // immediately.  Instead we protect them and keep them around until the next

2 spaces.
Attachment #8640552 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/cad7572d811e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.