Closed Bug 1188937 Opened 4 years ago Closed 4 years ago

Only add webpush interfaces to build if webpush is enabled.

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: nsm, Assigned: nsm)

Details

Attachments

(1 file)

Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Attachment #8640547 - Flags: review?(kcambridge)
Comment on attachment 8640547 [details]
MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge

Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Comment on attachment 8640547 [details]
MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge

https://reviewboard.mozilla.org/r/14333/#review12963

::: toolkit/content/aboutServiceWorkers.js:123
(Diff revision 2)
> +  if (PushNotificationService) {

I think lazy getters will still throw if the interface doesn't exist. Maybe remove the getter, and just wrap `getService` in a `try...catch` like you did in `sanitize.js`?
Attachment #8640547 - Flags: review?(kcambridge)
Comment on attachment 8640547 [details]
MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge

Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Attachment #8640547 - Flags: review?(kcambridge)
Comment on attachment 8640547 [details]
MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge

I made a reviewboard mistake, please ignore
Attachment #8640547 - Flags: review?(kcambridge)
Comment on attachment 8640547 [details]
MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge

Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Attachment #8640547 - Flags: review?(kcambridge)
Attachment #8640547 - Flags: review?(kcambridge) → review+
Comment on attachment 8640547 [details]
MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge

https://reviewboard.mozilla.org/r/14333/#review13005

Ship It!
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9a5f4793b17fb8df0f1b3b2d5bee606968b270b4
changeset:  9a5f4793b17fb8df0f1b3b2d5bee606968b270b4
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Wed Jul 29 09:12:51 2015 -0700
description:
Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r=kitcambridge
https://hg.mozilla.org/mozilla-central/rev/9a5f4793b17f
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.