Closed
Bug 1188937
Opened 9 years ago
Closed 9 years ago
Only add webpush interfaces to build if webpush is enabled.
Categories
(Core :: DOM: Push Subscriptions, defect)
Core
DOM: Push Subscriptions
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Attachment #8640547 -
Flags: review?(kcambridge)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8640547 [details] MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8640547 [details] MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge https://reviewboard.mozilla.org/r/14333/#review12963 ::: toolkit/content/aboutServiceWorkers.js:123 (Diff revision 2) > + if (PushNotificationService) { I think lazy getters will still throw if the interface doesn't exist. Maybe remove the getter, and just wrap `getService` in a `try...catch` like you did in `sanitize.js`?
Attachment #8640547 -
Flags: review?(kcambridge)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8640547 [details] MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Attachment #8640547 -
Flags: review?(kcambridge)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8640547 [details] MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge I made a reviewboard mistake, please ignore
Attachment #8640547 -
Flags: review?(kcambridge)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8640547 [details] MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge
Attachment #8640547 -
Flags: review?(kcambridge)
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=845727b84041
|
|
||
Updated•9 years ago
|
Attachment #8640547 -
Flags: review?(kcambridge) → review+
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8640547 [details] MozReview Request: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r?kitcambridge https://reviewboard.mozilla.org/r/14333/#review13005 Ship It!
|
|
Assignee | |
Comment 9•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a5f4793b17fb8df0f1b3b2d5bee606968b270b4 changeset: 9a5f4793b17fb8df0f1b3b2d5bee606968b270b4 user: Nikhil Marathe <nsm.nikhil@gmail.com> date: Wed Jul 29 09:12:51 2015 -0700 description: Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r=kitcambridge
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9a5f4793b17f
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•