Closed Bug 1188951 Opened 5 years ago Closed 5 years ago

Let tab queues ride the trains

Categories

(Firefox for Android :: General, defect)

35 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed
relnote-firefox --- 42+
fennec 42+ ---

People

(Reporter: Margaret, Assigned: mhaigh)

References

Details

Attachments

(1 file)

Tab queues are still behind a nightly-only flag:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/confvars.sh#104

I believe we decided to let this ride the trains to beta, then listen for feedback to see if we need to turn it off for some reason.

bbermes, is this correct?
Flags: needinfo?(bbermes)
tracking-fennec: --- → ?
Bug 1188951 - Let tab queues ride the trains; r?sebastian

Just getting a patch ready, so we can land when we get the go-ahead.
Attachment #8642421 - Flags: review?(s.kaspari)
Attachment #8642421 - Flags: review?(s.kaspari) → review+
Comment on attachment 8642421 [details]
MozReview Request: Bug 1188951 - Let tab queues ride the trains; r?sebastian

https://reviewboard.mozilla.org/r/14721/#review13273

Yeah \o/
If we are not sure we want to release this code I would rather use ifdef EARLY_BETA_OR_EARLIER https://wiki.mozilla.org/Platform/Channel-specific_build_defines
Flags: needinfo?(mhaigh)
(In reply to :Margaret Leibovic from comment #0)
> Tab queues are still behind a nightly-only flag:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/confvars.sh#104
> 
> I believe we decided to let this ride the trains to beta, then listen for
> feedback to see if we need to turn it off for some reason.
> 
> bbermes, is this correct?

Correct, thanks for checking.
Flags: needinfo?(bbermes)
Blocks: tab-queue
No longer blocks: tp-v1
Comment on attachment 8642421 [details]
MozReview Request: Bug 1188951 - Let tab queues ride the trains; r?sebastian

Bug 1188951 - Let tab queues ride the trains; r?sebastian

Edited to reflect new requirements in bug
Flags: needinfo?(mhaigh)
I see that the patch now uses the EARLY_BETA_OR_EARLIER flag Kevin mentioned in comment 3. We talked about whether that flag was needed or not, and decided it wasn't.

If this patch lands with EARLY_BETA_OR_EARLIER, I want to see a new bug filed right away to remove EARLY_BETA_OR_EARLIER and just always enabled Tab Queues. I want that bug marked as tracking Fx42.

If Fx42 ships with Tab Queues disabled because we just forgot to remove a flag, well it won't be pretty.
I wasn't aware that the final decision was to let it ride the train.  I'm going to land the initial patch and if we have any issues with it then we can hide it behind a flag again, although I'm hoping that won't be needed.
url:        https://hg.mozilla.org/integration/fx-team/rev/ca2464a414a677c789ca69e5fb1fafd372de480a
changeset:  ca2464a414a677c789ca69e5fb1fafd372de480a
user:       Martyn Haigh <mhaigh@mozilla.org>
date:       Wed Aug 05 17:27:50 2015 +0100
description:
Bug 1188951 - Let tab queues ride the trains; r=sebastian
(In reply to Martyn Haigh (:mhaigh) from comment #7)
> I wasn't aware that the final decision was to let it ride the train.  I'm
> going to land the initial patch and if we have any issues with it then we
> can hide it behind a flag again, although I'm hoping that won't be needed.

Yeah, I think there was some confusion here about my "listen for feedback" comment. I think we should have tab queues ready to ride the trains, and in the (hopefully unlikely) event that we get negative feedback, we can turn it off on beta. But the default plan is to ship it.
https://hg.mozilla.org/mozilla-central/rev/ca2464a414a6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
tracking-fennec: ? → 42+
We probably want to relnote this.
Can someone provide some wording for this?

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Thanks!
relnote-firefox: --- → ?
Depends on: 1194199
This is in the release notes with "Open external URLs from Android apps in the background" as wording.
By the way, I am using it and I love it!
You need to log in before you can comment on or make changes to this bug.