1189011 - build failure - js/src/jsfriendapi.h: #define JS_CHECK_STACK_SIZE(limit, sp) -- syntax error #if JS_STACK_GROWTH_DIRECTION > 0

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ian Stakenvicius]

Attachment: Fix syntax error in jsfriendapi.h for hppa

Building on HPPA, which is possibly the only platform that set JS_STACK_GROWTH_DIRECTION > 0, results in lots of errors like the following:

In file included from /var/tmp/portage/www-client/firefox-38.1.0/work/mozilla-esr38/dom/bindings/BindingUtils.h:10:0,
                 from /var/tmp/portage/www-client/firefox-38.1.0/work/mozilla-esr38/dom/bindings/BindingUtils.cpp:7,
                 from /var/tmp/portage/www-client/firefox-38.1.0/work/mozilla-esr38/ff/dom/bindings/Unified_cpp_dom_bindings0.cp
p:2:
/var/tmp/portage/www-client/firefox-38.1.0/work/mozilla-esr38/dom/bindings/BindingUtils.cpp: In function 'nsresult mozilla::dom:
:ReparentWrapper(JSContext*, JS::Handle<JSObject*>)':
../../dist/include/jsfriendapi.h:978:56: error: expected ')' before '{' token
         if (!JS_CHECK_STACK_SIZE(limit, &stackDummy_)) {                        \


This is caused by a simple syntax error in js/src/jsfriendapi.h that can be fixed with the attached patch.

Please consider backporting this to esr38 ot support future ESR builds out of the box on hppa (and of course m-c).

Note that I did not run this patch through try, since the '#if JS_STACK_GROWTH_DIRECTION > 0' codepath is never reached in try tests.

Comment 1

[Ian Stakenvicius]

Comment on attachment 8640646 [details] [diff] [review]
Fix syntax error in jsfriendapi.h for hppa

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:  Bug is a compile failure, ESRs will not build on hppa platform without this patch applied.
User impact if declined: hppa systems will not be able to package an update newer than 31.x ESR without this patch

Fix Landed on Version:

Risk to taking this patch (and alternatives if risky): none, applies to HPPA codepath only and that codepath currently can't build.

String or UUID changes made by this patch: none

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8640646 [details] [diff] [review]
Fix syntax error in jsfriendapi.h for hppa

Beta38+

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #2)
> Beta38+

Rather, ESR38+

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcecb7d94a8f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/1af911893d38

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcecb7d94a8f