Closed Bug 1189020 Opened 9 years ago Closed 8 years ago

Replace |// unnamed namespace| with |// namespace| in mozilla::pkix

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox42 --- affected
firefox48 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch change-namespace-comments.patch (obsolete) — Splinter Review
Replace |// unnnamed namespace| with |// namespace|.

This is what Google suggests in its style guide, and somebody already changed one (but only one!) of these comments to the new style in bug 1182996.
Attachment #8640654 - Flags: review?(cykesiopka.bmo)
Assignee: nobody → brian
Comment on attachment 8640654 [details] [diff] [review]
change-namespace-comments.patch

Review of attachment 8640654 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

> Replace |// unnnamed namespace| with |// namespace|.
Nit: s/unnnamed/unnamed/
Attachment #8640654 - Flags: review?(cykesiopka.bmo) → review+
Summary: Replace |// unnnamed namespace| with |// namespace| in mozilla::pkix → Replace |// unnamed namespace| with |// namespace| in mozilla::pkix
This is a bug worth fixing but I don't have the time to finish this, so unassigning myself.
Assignee: brian → nobody
Status: ASSIGNED → NEW
The previous patch was already reviewed and only needed nit fixes, so we might as well get this landed. This patch just fixes the nits and rebases on top of something more recent.
Attachment #8640654 - Attachment is obsolete: true
Attachment #8731253 - Flags: review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d13639723c5
(I got tired of waiting for the Win7 xpcshell jobs to even start after 7+ hours and cancelled them. Looks like TH still thinks the jobs are pending.)
Assignee: nobody → brian
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: mozilla42 → mozilla48
https://hg.mozilla.org/mozilla-central/rev/4edfc0a88412
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.