1189081 - [Raptor] Forward adb for Marionette on more than localhost

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

Right now Raptor only forwards the adb connection for Marionette if the host is on localhost. Let's try and handle this forwarding on other hosts too.

NOTE: we will need to deploy this to a pre-release package version to test out on Jenkins automation before landing in a production version.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/13

Comment 2

[Robert Wood [:rwood]]

(In reply to :Eli Perelman from comment #1)
> Created attachment 8640746 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/13

This works fine on device but doesn't seem to work with the emulator (localhost). I keep getting this error:

/home/rwood/raptor/node_modules/marionette-client/lib/marionette/client.js:524
        throw e;
              ^
Error: Polling socket recv() timeout!

Logs: https://gist.github.com/rwood-moz/841410854584d14ad36b

Comment 3

[Robert Wood [:rwood]]

Perhaps this is Bug 1175080

Comment 4

[Robert Wood [:rwood]]

Comment on attachment 8640746 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/13

Ok I was finally able to get this to work successfully with the emulator. I'm assuming the marionette issue is unrelated and is the same issue as Bug 1188990. This worked fine on localhost, didn't try on a remote device.

Comment 5

[:Eli Perelman]

I'm going to modify this a little to add a couple more config flags to possibly pull from, so I'll send an updated PR.

Comment 6

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/16

Same as previous PR, just adds a new `forwardPort` option.

Comment 7

[Robert Wood [:rwood]]

Comment on attachment 8642527 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/raptor/pull/16

LGTM. Didn't test on a remote bitbar device, just locally. Detached device and tried reboot test with --forward-port 2828, worked. Changed --forward-port to 2827, and the test timed out creating driver/connecting to b2g, as expected.

Comment 8

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/raptor/commit/7b736c122119b219bb732e52f6c3dd624a8aa92f
In npm: @mozilla/raptor v1.5.0