Closed
Bug 1189121
Opened 9 years ago
Closed 9 years ago
Remove -moz prefixed gradient expressions from bedrock
Categories
(www.mozilla.org :: Bedrock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dholbert, Unassigned)
References
()
Details
(Whiteboard: [kb=1811914] [good first bug])
Attachments
(2 files)
As noted in bug 1176496 comment 24, bedrock's tabzilla.less file currently uses "-moz-linear-gradient" (followed by a standard linear-gradient expression): #tabzilla-panel #tabzilla-nav a:active { background: #43a6e2; background: -moz-linear-gradient(top, #43a6e2 0%, #247ac1 100%); background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#43a6e2), color-stop(100%,#247ac1)); background: -webkit-linear-gradient(top, #43a6e2 0%,#247ac1 100%); background: -o-linear-gradient(top, #43a6e2 0%,#247ac1 100%); background: -ms-linear-gradient(top, #43a6e2 0%,#247ac1 100%); background: linear-gradient(top, #43a6e2 0%,#247ac1 100%); https://github.com/mozilla/bedrock/blob/82307473ff5be27554fd4c818362ecfafd4aa9f4/media/css/tabzilla/tabzilla.less#L728 We're looking to drop support for "-moz-linear-gradient" (or at least deprecate it), and even while it still works, it's not useful because we've shipped the standard version since Firefox 16 (since bug 752187). So -- let's remove this expression from tabzilla.less.
Reporter | ||
Comment 1•9 years ago
|
||
There are usages in several files actually, not just tabzilla.less: https://github.com/mozilla/bedrock/search?utf8=%E2%9C%93&q=-moz-linear-gradient https://github.com/mozilla/bedrock/search?utf8=%E2%9C%93&q=-moz-radial-gradient At first glance, it looks like all of them have unprefixed linear-gradient / radial-gradient expressions after the prefixed ones, so the prefixed ones should be removable without changing behavior (since they're already being overridden by the standards-compliant versions later on).
Summary: Remove -moz-linear-gradient expression from bedrock tabzilla.less file → Remove -moz prefixed gradient expressions from bedrock
Comment 2•9 years ago
|
||
Thanks for the report! We removed -moz-linear-gradient from our Less mixins quite some time ago, but looks like there are still some occurrences left in the code base where we didn't use the mixin. We'll get these cleaned up :)
Updated•9 years ago
|
Whiteboard: [kb=1811914]
Updated•9 years ago
|
Whiteboard: [kb=1811914] → [kb=1811914] [good first bug]
Pull request: https://github.com/mozilla/bedrock/pull/3230
Pull Request: https://github.com/mozilla/bedrock/pull/3230
Removed: background: -moz-linear-gradient(top, #43a6e2 0%, #247ac1 100%); /// I also have a pull request, https://github.com/mozilla/bedrock/pull/3230 , but I accidentally did edits on master and now when I make a branch, those commits come with it, messing up pull requests.
Attachment #8650910 -
Flags: review?(agibson)
Sorry about all of this! This is the final pull request, everything is fixed now: https://github.com/mozilla/bedrock/pull/3231
Attachment #8650910 -
Attachment is patch: false
Attachment #8650910 -
Flags: review?(agibson)
Final Final Pull Request :D :agibson https://github.com/mozilla/bedrock/pull/3238
Flags: needinfo?(agibson)
Alex Gibson, I still can't get rid of the one of the commits, but it should be fine.
Flags: needinfo?(agibson)
Comment 9•9 years ago
|
||
I've taken Joseph's commit and opened a new PR for him here. Thanks, Joseph!
Comment 10•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/206af71cda597c871e5ae6009a5639d29b6289a8 [bug 1189121] Remove old CSS vendor prefixes from gradient expressions
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•