Closed
Bug 1189129
Opened 9 years ago
Closed 9 years ago
add crashstack annotations when aborting in gfxFontGroup::GetDefaultFont
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jtd, Assigned: jtd)
References
Details
Attachments
(1 file)
5.67 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
There are currently a whole slew of crasher bugs related to aborts within gfxFontGroup::GetDefaultFont. This happens when, for some reason, we can't find *any* font on the system to use. http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxTextRun.cpp#1899 Before we do this we should add more annotations to the crash report via gfxCriticalError. For example, how many fonts in the fontlist, whether errors occurred during global fontlist enumeration, whether the initialization routine was ever called, etc.
Assignee | ||
Comment 1•9 years ago
|
||
When no default font is found, note in the crashreport the number of calls to InitFontList, the number of fonts in the system fontlist, and the state of the fontloader thread.
Attachment #8642879 -
Flags: review?(bas)
Updated•9 years ago
|
Attachment #8642879 -
Flags: review?(bas) → review+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/638db7656bee
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Assignee | ||
Comment 4•9 years ago
|
||
To view the crashstack annotations added here: 1. Open the crashstack report Ex: https://crash-stats.mozilla.com/report/index/35dd3094-92b7-442e-b78a-876662150807 2. Click on the 'Metadata' tab 3. Look for 'GraphicsCriticalError' in the list Ex: |[0][GFX1]: no fonts - init: 1 fonts: 0 loader: 1 This indicates initialization occurred, no fonts are in the fontlist and the font loader thread is in the "waiting to fire" state, stateTimerOnDelay.
You need to log in
before you can comment on or make changes to this bug.
Description
•