Closed Bug 1189158 Opened 5 years ago Closed 5 years ago

shutdown font loader thread in separate event

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox41 --- fixed
firefox42 --- fixed
thunderbird_esr38 44+ fixed

People

(Reporter: jtd, Assigned: jtd)

References

Details

Attachments

(1 file)

Bug 1070983, comment 4 indicates that we are aborting within layout code because no font can be found in the fontlist. When font updates occur we clear the fontlists and attempt to shutdown the async font loader thread. This causes the event loop to be spun and layout events to fire with the fontlists in an incomplete state.

The simple solution is to move the font loader thread shutdown to a separate event so that it doesn't spin the event loop with system fontlists in an incomplete state.
Do the call to shutdown the font loader thread in a separate event, so that when the event loop is spun, the system fontlist is setup correctly.
Attachment #8640952 - Flags: review?(m_kato)
Attachment #8640952 - Flags: review?(m_kato) → review+
https://hg.mozilla.org/mozilla-central/rev/3f05126269cb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8640952 [details] [diff] [review]
patch, move thread shutdown into separate event

Approval Request Comment
[Feature/regressing bug #]: GetDefaultFont failure, don't know cause precisely
[User impact if declined]: crashes will continue
[Describe test coverage new/current, TreeHerder]: has been stable in nightlies
[Risks and why]: minor change but should fix many of the GetDefaultFont-related aborts
[String/UUID change made/needed]: none
Attachment #8640952 - Flags: approval-mozilla-aurora?
Comment on attachment 8640952 [details] [diff] [review]
patch, move thread shutdown into separate event

Aurora+. Fix has been in m-c for a week.
Attachment #8640952 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
jtd in https://bugzilla.mozilla.org/show_bug.cgi?id=1192699#c21 suggested that we consider this patch as a possible TB38 branch land.
You need to log in before you can comment on or make changes to this bug.