1189165 - Empty panels, layout revisions

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Robin Andersen [:tecgirl]]

Attachment: emptyPanelExamples.zip

After some feedback let's update some visual and layout of the empty panels.

1) Return to visually centering—not actually centering the content. What does this mean? Visual center is ever-so-slightly above actual center. Actual center appears too low. Compensation should be about -50px.

2) Open up the padding from 10 to 15. This will necessitate an overflow of the button on Remote Tabs so the button will flow to the right like we do for Error pages (at least in landscape on the 5 and above).

3) Increase EmptyStateTitleFont, EmptyStateInstructionsFont, WelcomeScreenHeaderFont, TitleLabelFont by 3 exclusively for iPad (button size and text remain).

4) Adjust WelcomeScreenHeaderFont from 14 to 15. 

5) Adjust WelcomeScreenItemTextColor from UIColor.lightGrayColor() to UIColor.grayColor()


I've attached some mocks for comparison.

Comment 1

[Robin Andersen [:tecgirl]]

6) Add UIFontWeightLight to WelcomeScreenItemFont

Comment 2

[u536637]

Problem with #1, this cuts the reader panel off when rotated :o

Comment 4

[Bryan Munar (:bkmunar)]

Attachment: PR - i know will have nits, plz halp LOL

Comment 5

[Robin Andersen [:tecgirl]]

Comment on attachment 8642596 [details] [review]
PR - i know will have nits, plz halp LOL

All good!

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8642596 [details] [review]
PR - i know will have nits, plz halp LOL

On the right track, but I'd like this to be more Auto Layout-friendly so this is easier to maintain. In particular, see if you can remove the device-specific constraints, and try to avoid remaking constraints where possible.