Closed Bug 1189166 Opened 4 years ago Closed 4 years ago

Cleanup some PSM test generation files post Bug 1181823

Categories

(Core :: Security: PSM, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

Details

Attachments

(1 file)

Bug 1181823 converted several tests to generate certs at build time, and in the process left some dead code and files.

I decided to defer these changes to a separate bug since the patch in Bug 1181823 was large enough already.
Bug 1189166 - Cleanup some PSM test generation files post Bug 1181823.
Attachment #8640936 - Flags: review?(dkeeler)
Comment on attachment 8640936 [details]
MozReview Request: Bug 1189166 - Cleanup some PSM test generation files post Bug 1181823.

https://reviewboard.mozilla.org/r/14401/#review13223

Looks good to me. I was going to say we should skip this since I'm working on converting the rest of the test_keysize certificates to use pycert (which will remove most of these files anyway), but since you've already written this patch, I think it's worthwhile to go ahead with it.
Attachment #8640936 - Flags: review?(dkeeler) → review+
Ah, oh well. Thanks for the review anyways!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc6d1e7c397
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ea2c3ec477c6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.