Closed Bug 1189250 Opened 5 years ago Closed 5 years ago

Clean up .toolbarbutton-1[type=menu] and .toolbarbutton-1[type=panel] styling

Categories

(Firefox :: Theme, defect)

All
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
* toolbarbutton-badge-container doesn't exist, it's called toolbarbutton-badge-stack now
* feed-button isn't a menu button as far as I can see
* back-button and forward-button don't have badges
* by always setting badged-button on PanelUI-menu-button, we don't need the selector to cover the case of that button not having that class (app.update.badge=false)
Attachment #8641021 - Flags: review?(jaws)
(In reply to Dão Gottwald [:dao] from comment #0)
> * by always setting badged-button on PanelUI-menu-button, we don't need the
> selector to cover the case of that button not having that class
> (app.update.badge=false)

Hmm, I hadn't realized that app.update.badge was false by default in release builds. In that case I guess we shouldn't make that change since it would make the button needlessly complex for those builds?
Attached patch patch v2Splinter Review
(In reply to Dão Gottwald [:dao] from comment #1)
> (In reply to Dão Gottwald [:dao] from comment #0)
> > * by always setting badged-button on PanelUI-menu-button, we don't need the
> > selector to cover the case of that button not having that class
> > (app.update.badge=false)
> 
> Hmm, I hadn't realized that app.update.badge was false by default in release
> builds. In that case I guess we shouldn't make that change since it would
> make the button needlessly complex for those builds?

I reverted this change
Attachment #8641021 - Attachment is obsolete: true
Attachment #8641021 - Flags: review?(jaws)
Attachment #8641334 - Flags: review?(jaws)
Attachment #8641334 - Flags: review?(jaws) → review+
(In reply to Dão Gottwald [:dao] from comment #0)
> * toolbarbutton-badge-container doesn't exist, it's called
> toolbarbutton-badge-stack now
Oops, did I overlook another occurrence? Sorry about that.
https://hg.mozilla.org/mozilla-central/rev/3f242232b264
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.