1189282 - Refactor parser BindData class

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: refactor-binder

BindData is a helper class that's used to create bindings.  To handle the different kinds of bindings this currently has the caller set a function pointer to determine what happens when we bind.  This is pretty confusing.

The patch refactors BindData to use an enum to represent the different binding kinds and switches on the kind when we bind.  Also it makes more of the data private and adds assertions that the class is used correctly.

Comment 1

[Eric Faust [:efaust]]

Comment on attachment 8641046 [details] [diff] [review]
refactor-binder

Review of attachment 8641046 [details] [diff] [review]:
-----------------------------------------------------------------

Yes yes yes. Thank you for bringing C++ to what was clearly an old C holdover.

Sorry about the review delay. The patch is great.

::: js/src/frontend/Parser.cpp
@@ +1162,5 @@
>  /*
> + * Helper class for creating bindings.
> + *
> + * The same instance can be used more than once by repeatedly calling
> + * setNameNode() followed by bind().

This comment would have saved me a ton of time the first time I used this. Thanks.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13aaf1d82d6f

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/13aaf1d82d6f