1189352 - NSPR_LOG_FILE=<absolute path> still not working from sandbox child process on Windows

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Bob Owen (:bobowen)]

+++ This bug was initially created as a clone of Bug #1171796 +++

Realised that the last minute refactor I did before review for the patch for bug 1171796, meant that I broke the patch for absolute paths.

Before I was checking to see if it was an absolute path first, but I switched it around.

Unfortunately the validation for AppendRelativeNativePath, doesn't check very well for absolute paths and so you end up with something like: c:\foo\c:\bar\log.txt

Just need to switch the logic back to fix that ... and re-test it more thoroughly this time. :-)

Comment 1

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=38bbb0a432a9

Comment 2

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1189352: Fix NSPR_LOG_FILE with absolute paths for sandboxed child on Windows. r?bbondy

Bug 1189352: Fix NSPR_LOG_FILE with absolute paths for sandboxed child on Windows. r?bbondy

Comment 3

[Bob Owen (:bobowen)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf9ce6c8403454172e5211c84da133c495e0e7b
changeset:  2bf9ce6c8403454172e5211c84da133c495e0e7b
user:       Bob Owen <[e-mail]>
date:       Mon Aug 03 07:58:43 2015 +0100
description:
Bug 1189352: Fix NSPR_LOG_FILE with absolute paths for sandboxed child on Windows. r=bbondy

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2bf9ce6c8403