1189376 - Should print link to perfherder for try pushes w/ talos jobs in email as well

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

We now print a link to perfherder in the console when someone pushes to try with talos jobs (bug 1185676). We should do the same in the emails we send to people after they push to try.

:gps, what would I need to modify to do that? I'm not seeing the email template in `version-control-tools`.

Comment 1

[Gregory Szorc [:gps]]

I have no clue who is responsible for the Try emails. My guess is it is something in releng scheduling land.

Comment 2

[William Lachance (:wlach)]

catlee pointed me here on irc: http://hg.mozilla.org/build/buildbotcustom/file/a84859c4886a/status/generators.py#l4

Comment 3

[William Lachance (:wlach)]

Attachment: Add link to perfherder for talos pushes

I think this should do the trick. I'm not sure how to test.

Flagging :bhearsum for review, hopefully he's the right person (just guessing based on hg history).

Comment 4

[William Lachance (:wlach)]

Ben, could I ask a gigantic favor and get you to land/test this for me? I don't know the procedure.

To test, just do a try push with any talos job and make sure the email continues to send and that it contains the link to perfherder (and the link works as expected).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8641924 [details] [diff] [review]
Add link to perfherder for talos pushes

https://hg.mozilla.org/build/buildbotcustom/rev/ba27e51a5823

Comment 6

[William Lachance (:wlach)]

Hmm, it's pushed but I don't see the new stuff in the try emails. I suspect something else needs to change. Re-needinfo'ing bhearsum for that

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Needs a reconfig first. The bug should get updated when it's in production.

Comment 8

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/ba27e51a5823