Closed Bug 1189410 Opened 5 years ago Closed 5 years ago

Dev Edition back button doesn't match the height of the forward button / location bar

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
42 Branch
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox41 --- unaffected
firefox42 --- fixed

People

(Reporter: metasieben, Assigned: bgrins)

References

Details

(Keywords: regression)

Attachments

(3 files)

misaligned back-button & loacationbar
6.93 KB, image/png
Details
MozReview Request: Bug 1189410 - Override margin-top and margin-bottom for back button to make it match location bar in Dev Edition;r=paolo
40 bytes, text/x-review-board-request
Paolo
: review+
Details
MozReview Request: Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev Edition theme;r=paolo
40 bytes, text/x-review-board-request
Paolo
: review+
Details 
The back-button and the locationbar are mis-aligned, as the locationbar's height has been increased. is this an intentional change?

Could be a dupe of Bug 1184097, but since i'm seeing this on OS X, i'm not sure.
Depends on: 1184097
Note that the height becomes correct when the window is out of focus
Status: UNCONFIRMED → NEW
Ever confirmed: true
We are running out of time to get a fix in for 42.  This is a pretty obvious issue though, we need to track down a regression range and get a fix ASAP
status-firefox41: --- → unaffected
status-firefox42: --- → affected
Keywords: regression, regressionwindow-wanted
Tracked down the regression - looks like Bug 1185362

https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=fa418b120a3b&tochange=2bb4fef68522
Blocks: 1185362
Keywords: regressionwindow-wanted
Summary: Locationbar and Back-Button don't line up [DevEdition-Theme] → Dev Edition back button doesn't match the height of the forward button / location bar
Bug 1189410 - Override margin-top and margin-bottom for back button to make it match location bar in Dev Edition;r=paolo
Attachment #8645012 - Flags: review?(paolo.mozmail)
Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev Edition theme;r=paolo
Attachment #8645013 - Flags: review?(paolo.mozmail)
(In reply to Brian Grinstead [:bgrins] from comment #6)
> Created attachment 8645013 [details]
> MozReview Request: Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev
> Edition theme;r=paolo
> 
> Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev Edition
> theme;r=paolo

Paolo, you had pointed this out in your review for Bug 1185362 (Comment 10) but for some reason it wasn't included in the final push
Comment on attachment 8645012 [details]
MozReview Request: Bug 1189410 - Override margin-top and margin-bottom for back button to make it match location bar in Dev Edition;r=paolo

Bug 1189410 - Override margin-top and margin-bottom for back button to make it match location bar in Dev Edition;r=paolo
Comment on attachment 8645013 [details]
MozReview Request: Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev Edition theme;r=paolo

Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev Edition theme;r=paolo
Comment on attachment 8645012 [details]
MozReview Request: Bug 1189410 - Override margin-top and margin-bottom for back button to make it match location bar in Dev Edition;r=paolo

https://reviewboard.mozilla.org/r/15355/#review13825

Ship It!
Attachment #8645012 - Flags: review?(paolo.mozmail) → review+
Comment on attachment 8645013 [details]
MozReview Request: Bug 1189410 - Set --backbutton-urlbar-overlap to 0 in Dev Edition theme;r=paolo

https://reviewboard.mozilla.org/r/15357/#review13827

Ship It!
Attachment #8645013 - Flags: review?(paolo.mozmail) → review+
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/cba2d3671604
https://hg.mozilla.org/mozilla-central/rev/f5d047d6918d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.