1189413 - Regression: Unable to backspace a URL in edit-mode

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently one is unable to backspace a URL in edit-mode.

Visit http://reddit.com
Tap the address-bar
Attempt to back-space

Tests?

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/833

Looks like the removal of this line was causing problems. I know both of you guys worked on this recently for fixing crashes and such. Is there any reason we should not do this?

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8641211 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/833

This is a regression from bug 1177597. I think codester removed it because in general, deleteBackward() will end up triggering SELtextDidChange() because a character will be deleted. The initial highlight is an exception, though, since we set the cursor to the beginning of the text field when doing that highlight, meaning deleteBackward() has no characters to delete. Note that an alternative fix would be to remove this line [1], but we probably don't want to do that since we want the URL bar to show the beginning of the text when we first select it.

So in short, I think this fix is fine. It'd be good to have a simple test for this if you don't mind!

[1] https://github.com/mozilla/firefox-ios/blob/c0381538788ca27d6a4c30a8e25fa743840729eb/Client/Frontend/Widgets/AutocompleteTextField.swift#L62

Comment 3

[Stephan Leroux [:sleroux]]

Added UI test for scenario: https://github.com/mozilla/firefox-ios/pull/833/files#diff-ddb707040b26de960719e3645dcfcc5dR115

I'll go ahead and merge this in.

Comment 4

[Stephan Leroux [:sleroux]]

Merged.