1189423 - Add MOZ_COUNT_CTOR/DTOR for nsXPTCStubBase

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

This would have caught bug 1074416 in regular leak checking builds.

Comment 1

[Andrew McCreight [:mccr8]]

I guess we must not clean these up because I'm seeing megabytes of these leaking in each run.
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f4032142f5e

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Add MOZ_COUNT_CTOR/DTOR for nsXPTCStubBase.

I'm not going to have time to investigate what is going wrong any time soon, but here's the patch.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Remove superfluous |new| result check.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Add MOZ_COUNT_CTOR/DTOR for nsXPTCStubBase.

I decided to see if I could reproduce the leak locally. Then I realized that in my original patch I used MOZ_COUNT_CTOR in both the constructor and destructor, which would explain the leaks. Hopefully this version will work out better.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a7cb1ea459a

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8641310 [details] [diff] [review]
part 2 - Remove superfluous |new| result check.

try is green

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4b5cc7433b
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1e940e09127

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a4b5cc7433b
https://hg.mozilla.org/mozilla-central/rev/b1e940e09127