bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.
Please report any other irregularities here.
44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Let's get the old Fennec product out of Socorro. This is not to be confused with FennecAndroid, which is still there and useful. Let's purge any one off weirdness we have for supporting it and accelerate the end date on the existing products to be ::now
Yes please. I think the only thing that could be a bit harder here than with MetroFirefox is that I think we originally had been copying over versions from Fennec to FennecAndroid. But we really should clean this all up anyhow.
The only place I've found where it does some sort of stored procedure to do with Fennec is here: https://github.com/mozilla/socorro/blob/7f28d41daba11517d38b066dc87c93b20b1ba793/socorro/external/postgresql/raw_sql/procs/update_product_versions.sql#L98-L126 It clones each release with a product name called "Fennec" into "WebappRuntimeMobile". We can kill that and there'd be an implicit effect of killing two birds with one stone. In terms of getting rid of it from the drop-down, I'm guessing we just need to sunset every product_version where the product_name is Fennec (not FennecAndroid). Is that correct Kairo?
From all I know, we want to keep WebappRuntimeMobile around, but it should clone from FennecAndroid, not from Fennec, I guess we made a mistake when we set that up originally.
(In reply to Peter Bengtsson [:peterbe] from comment #2) > The only place I've found where it does some sort of stored procedure to do > with Fennec is here I also get the impression that somehow the FTP scraper might be feeding new versions to Fennec - it should only feed new ones to FennecAndroid (and get those copied to WebappRuntimeMobile).
(In reply to Robert Kaiser (:firstname.lastname@example.org) from comment #3) > From all I know, we want to keep WebappRuntimeMobile around, but it should > clone from FennecAndroid, not from Fennec, I guess we made a mistake when we > set that up originally. Not only is it not called "Fennec" in releases, it's not even called "FennecAndroid" :) breakpad=> select product_name, count(product_name) as c from releases_raw group by product_name order by c desc limit 100; product_name | c --------------+------- firefox | 58360 mobile | 16534 thunderbird | 16058 b2g | 12528 seamonkey | 7749 camino | 1 (6 rows)
Assignee: nobody → peterbe
Created attachment 8698012 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3137
Hmm, your select statement from comment #6 talks about releases_raw but the SQL in your patch about releases_recent - are those different tables? Are they using the same or different product names? (Note that we rewrite from "mobile" to "Fennec"/"FennecAndroid" when processing releases_raw AFAIK)
The "mobile" name should be confined to FTP scraping only, outside of FTP it always should be something that includes "Fennec" in the name.
Kairo, `releases_recent` is a temp table built from `releases_raw`. `releases_raw` is built from the ftpscraper. If you look at the `product_name` column in `releases_raw` you'll see it's called "mobile". (Terrible name by the way!!)
(In reply to Peter Bengtsson [:peterbe] from comment #10) > (Terrible name by the way!!) True, coming from a lot of history in the way the product was created that nowadays is Android-specific Fennec. That "mobile" is just a directory name on FTP/archive.m.o and should not be used anywhere else, hopefully.
(In reply to Peter Bengtsson [:peterbe] from comment #10) > Kairo, `releases_recent` is a temp table built from `releases_raw`. Before the transformations of product names etc. or after them? (I know, this is messy.)
(In reply to Robert Kaiser (:email@example.com) from comment #3) > From all I know, we want to keep WebappRuntimeMobile around, but it should > clone from FennecAndroid, not from Fennec, I guess we made a mistake when we > set that up originally. OK, this changed recently as I just heard, the webapp runtimes are deprecated, we can remove all the copying we have, both to WebbappRuntimeMobile and (from Firefox) to WebappRuntime.
I tried several times and could never figure out where the Fennec production versions are coming from. There's some musky old stored procedure at play somewhere. What the ftpscraper pulls down is "mobile" and that goes into release_raw or something and then some stored procedure converts that into rows in product_versions. Somewhere there it makes the "conversion" from calling it "mobile" to calling it "FennecAndroid" (and "Fennec"). I could never find and control that piece of dark code.
Assignee: peterbe → nobody
You need to log in before you can comment on or make changes to this bug.