Pass tracking information to BrowserElement's mozbrowsersecuritychange event

RESOLVED FIXED in Firefox 43

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

(Depends on: 1 bug)

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently the code doesn't have correct handling in mozbrowsersecuritychange, it treats mixed content and tracking protection info as mutually exclusive from the secure state. 

This effectively makes it impossible for a a BrowserElement to determine if tracking protection was used. 

I'm going to change this, while preserving old code by sending this info:

> sendAsyncMsg('securitychange', {
>        state: securityStateDesc,
>        trackingState: trackingStateDesc,
>        mixedState: mixedStateDesc,
>        extendedValidation: isEV,
>        trackingContent: isTrackingContent,
>        mixedContent: isMixedContent,
>      });
(Assignee)

Comment 1

3 years ago
Created attachment 8641723 [details] [diff] [review]
sec-changes.diff

So this is working correctly when I manually test, but I'm having trouble getting the test to work properly with respect to tracking detection.

I've actually played with the test for several hours. I did confirm that the UrlClassification/tracking protection settings are in effect and if I add the tracking image outside the iframe it gets blocked.   It seems like the iframe doesn't see the tracking protection settings though. 

If you have some ideas on how to fix I'd be happy to try them out, or if not I'd like to land this anyway since it's more correct than what's there and provides more info to Graphene browsers.  I'm doing pretty much the same thing in my manual test code so I think it's a test env related problem.
Attachment #8641723 - Flags: review?(fabrice)
Comment on attachment 8641723 [details] [diff] [review]
sec-changes.diff

Review of attachment 8641723 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Can you file a follow-up to investigate the remaining testing issue?
Attachment #8641723 - Flags: review?(fabrice) → review+
(Assignee)

Comment 3

3 years ago
> Thanks! Can you file a follow-up to investigate the remaining testing issue?

Sure thing, thanks.
(Assignee)

Updated

3 years ago
Depends on: 1192237
(Assignee)

Comment 4

3 years ago
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e7facece2cae4e9aea8fe926af26d5c1481d5f3f
changeset:  e7facece2cae4e9aea8fe926af26d5c1481d5f3f
user:       Brian R. Bondy <netzen@gmail.com>
date:       Mon Aug 10 16:59:59 2015 -0400
description:
Bug 1189494 - Pass tracking information to BrowserElement's mozbrowsersecuritychange event. r=fabrice
https://hg.mozilla.org/mozilla-central/rev/e7facece2cae
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.