Assets on Remote Tabs panel display soft

RESOLVED FIXED

Status

()

Firefox for iOS
Home screen
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tecgirl, Assigned: karim)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

Attachments

(4 attachments)

(Reporter)

Description

2 years ago
Created attachment 8641276 [details]
device-type-assets.png

The device-type icons on the Remote Tabs panel are displaying soft. See side-by-side comparison with the Send Tab list—so one can assume it's not the assets.
(Reporter)

Updated

2 years ago
tracking-fxios: --- → ?
(Assignee)

Updated

2 years ago
Assignee: nobody → kbenhmida
(Assignee)

Comment 1

2 years ago
Already working on this. The assets are good, the problem was in the code. PR on its way.
(Assignee)

Comment 2

2 years ago
Robin, can you make 36 × 24 assets for deviceTypeDesktop and deviceTypeMobile. We currently have 36 x 25, and the image view that displays the icons has a 24 points height, so the assets are slightly resized which is why they look soft.
Flags: needinfo?(randersen)
(Reporter)

Comment 3

2 years ago
:karim will this change how the display on the Send Tab list?
Flags: needinfo?(randersen)
(Reporter)

Updated

2 years ago
Flags: needinfo?(kbenhmida)
(Assignee)

Comment 4

2 years ago
No it won't.
Flags: needinfo?(kbenhmida)
tracking-fxios: ? → +
Karim, does this need new assets? Comment 1 and Comment 2 disagree.
Flags: needinfo?(randersen)
Flags: needinfo?(kbenhmida)
(Assignee)

Comment 6

2 years ago
I can do a workaround to display the current assets correctly with code (basically resizing the UIImageView to avoid the small image stretch that makes the icons look soft), but I think its better to have new assets with the dimensions specified in Comment 2
Flags: needinfo?(kbenhmida)
(Reporter)

Updated

2 years ago
Assignee: kbenhmida → randersen
Flags: needinfo?(randersen)
(Reporter)

Comment 7

2 years ago
Created attachment 8643403 [details]
deviceTypes.zip

give these a whirl.
(Reporter)

Updated

2 years ago
Assignee: randersen → kbenhmida
(Reporter)

Comment 8

2 years ago
Created attachment 8643407 [details]
deviceTypeDesktop-replacements.zip

try these.
Status update, Karim?
Status: NEW → ASSIGNED
Flags: needinfo?(kbenhmida)
(Assignee)

Comment 10

2 years ago
Created attachment 8645826 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/890
Flags: needinfo?(kbenhmida)
Attachment #8645826 - Flags: review?(randersen)
(Reporter)

Comment 11

2 years ago
Comment on attachment 8645826 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/890

Looks good!
Attachment #8645826 - Flags: review?(randersen) → review+
(Assignee)

Comment 12

2 years ago
Merged PR: https://github.com/mozilla/firefox-ios/commit/a82509ff70bf3425806cb6bc4aa93fedc1a69792
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.