`pushManager.getSubscription()` should return `null` for nonexistent push subscriptions in workers

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lina, Assigned: lina)

Tracking

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

It currently throws an assertion error.
Bug 1189543 - `pushManager.getSubscription()` should return `null` for nonexistent push subscriptions in workers. r?nsm
Attachment #8641330 - Flags: review?(nsm.nikhil)
https://reviewboard.mozilla.org/r/14469/#review13095

::: dom/push/test/worker.js:3
(Diff revision 1)
>  

Could you add a comment here saying this worker is used for 2 tests and one of them uses the push handler and the other uses the message handler.

::: dom/push/test/test_push_manager_worker.html:51
(Diff revision 1)
> +  function getEndpointFromWorker(pushSubscription) {

getNewEndpointFromWorker.
Comment on attachment 8641330 [details]
MozReview Request: Bug 1189543 - `pushManager.getSubscription()` should return `null` for nonexistent push subscriptions in workers. r?nsm

https://reviewboard.mozilla.org/r/14471/#review13097

Ship It!
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/96bb759922a1cdf2b9ce3642ec6de84c80ae0741
changeset:  96bb759922a1cdf2b9ce3642ec6de84c80ae0741
user:       Kit Cambridge <kcambridge@mozilla.com>
date:       Thu Jul 30 15:31:48 2015 -0700
description:
Bug 1189543 - `pushManager.getSubscription()` should return `null` for nonexistent push subscriptions in workers. r=nsm
https://hg.mozilla.org/mozilla-central/rev/96bb759922a1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Backed out for frequent crashes/asserts.
https://treeherder.mozilla.org/logviewer.html#?job_id=4035935&repo=fx-team

https://hg.mozilla.org/integration/mozilla-inbound/rev/68e18c68844b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla42 → ---
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0e68d7a16ed852a833ac0d3d4b5ff0c54bf2573b
changeset:  0e68d7a16ed852a833ac0d3d4b5ff0c54bf2573b
user:       Kit Cambridge <kcambridge@mozilla.com>
date:       Tue Aug 04 13:43:23 2015 -0700
description:
Bug 1189543 - `pushManager.getSubscription()` should return `null` for nonexistent push subscriptions in workers. r=nsm
https://hg.mozilla.org/mozilla-central/rev/0e68d7a16ed8
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5e5cf1ff3d9974eccf9c236343dce9281773bad1
changeset:  5e5cf1ff3d9974eccf9c236343dce9281773bad1
user:       Kit Cambridge <kcambridge@mozilla.com>
date:       Thu Aug 06 10:12:59 2015 -0700
description:
Back out changeset 0e68d7a16ed8 (bug 1189543) for mochitest-push timeouts.
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/96544133a324b9dc3c4cf512982a346dbb656935
changeset:  96544133a324b9dc3c4cf512982a346dbb656935
user:       Kit Cambridge <kcambridge@mozilla.com>
date:       Thu Aug 06 10:15:00 2015 -0700
description:
Bug 1189543 - `pushManager.getSubscription()` should return `null` for nonexistent push subscriptions in workers. r=nsm
You need to log in before you can comment on or make changes to this bug.