Closed Bug 1189550 Opened 5 years ago Closed 5 years ago

In parent process, cpmm.initialProcessData should be same as ppmm.initialProcessData

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The typical way to use initialProcessData is to set it on the ppmm and read it from the cpmm. That doesn't work for the cpmm in the chrome process. This patch fixes that.

I also threw in a patch for bug 1184115. It makes it so that ppmm is undefined in the child process. I don't think there's any reason you would ever want it there.
Attachment #8641338 - Flags: review?(bugs)
Comment on attachment 8641338 [details] [diff] [review]
patch

always {} with if.
Attachment #8641338 - Flags: review?(bugs) → review+
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4e3821b236f9 since one of the 2 changes seems to have caused:

for causing test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=12405582&repo=mozilla-inbound
Flags: needinfo?(wmccloskey)
https://hg.mozilla.org/mozilla-central/rev/502c196722eb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Flags: needinfo?(wmccloskey)
You need to log in before you can comment on or make changes to this bug.