1189566 - Globally install push_urls hook

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect, P1)

Description

[Edmund Wong (:ewong)]

Currently when pushing to http://hg.mozilla.org/SeaMonkey/puppet, a
commit hook message appears; but it shows that I had pushed to
http://hg.mozilla.org/build/puppet/rev/<cset>, which isn't the case.

I believe it would lessen the confusion if the commit hook (or whatever
it is run when someone pushes to that repo) is changed to show
that the commit was pushed to http://hg.mozilla.org/SeaMonkey/puppet.

Comment 1

[Gregory Szorc [:gps]]

I'm sick and tired of these one-off bugs related to the push_urls hook. Let's just globally install the hook and be done with it.

We'll want to remove the hook for existing hgrc files once this is deployed or we may have the hook run multiple times.

I should have time to look at this in the next day or two, once bug 1189449 is out of the way.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: ansible/hg-ssh: globally install push_printurls hook (bug 1189566); r?fubar

ansible/hg-ssh: globally install push_printurls hook (bug 1189566); r?fubar

This hook is manually installed on many repos. It is generally useful.
Let's just install it globally so we don't have to continue spending
time managing it on all the repos.

The added config value matches exactly what exists in 94 repos on
hg.mozilla.org. Therefore, this is safe to deploy without any additional
changes to existing repository configs. There won't be multiple
invocations of the hook or anything like that.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8641857 [details]
MozReview Request: ansible/hg-ssh: globally install push_printurls hook (bug 1189566); r?fubar

ansible/hg-ssh: globally install push_printurls hook (bug 1189566); r?fubar

This hook is manually installed on many repos. It is generally useful.
Let's just install it globally so we don't have to continue spending
time managing it on all the repos.

The added config value matches exactly what exists in 94 repos on
hg.mozilla.org. Therefore, this is safe to deploy without any additional
changes to existing repository configs. There won't be multiple
invocations of the hook or anything like that.

Comment 4

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8641857 [details]
MozReview Request: ansible/hg-ssh: globally install push_printurls hook (bug 1189566); r?fubar

https://reviewboard.mozilla.org/r/14619/#review13219

Ship It!

Comment 5

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/a502fb4b12f77cd340387cf115096a164d3f26b8
changeset:  a502fb4b12f77cd340387cf115096a164d3f26b8
user:       Gregory Szorc <[e-mail]>
date:       Mon Aug 03 10:18:45 2015 -0700
description:
ansible/hg-ssh: globally install push_printurls hook (bug 1189566); r=fubar

This hook is manually installed on many repos. It is generally useful.
Let's just install it globally so we don't have to continue spending
time managing it on all the repos.

The added config value matches exactly what exists in 94 repos on
hg.mozilla.org. Therefore, this is safe to deploy without any additional
changes to existing repository configs. There shouldn't be multiple
invocations of the hook or anything like that.

Comment 6

[Gregory Szorc [:gps]]

I'll deploy this shortly.