Closed Bug 1189572 Opened 9 years ago Closed 9 years ago

Default page info window height is too small on Windows now that the Help button is added

Categories

(Firefox :: Page Info Window, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox39 --- affected
firefox40 --- affected
firefox41 --- affected
firefox42 --- affected
firefox43 --- fixed
firefox-esr38 --- unaffected

People

(Reporter: MattN, Assigned: nanonikhil, Mentored)

References

(Depends on 1 open bug)

Details

(Keywords: regression, Whiteboard: [lang=xul] [good first bug])

Attachments

(1 file)

The Help button is clipped in a new profile (with no persisted page info dialog size). Nothing was clipped before the help button was added so marking as a regression.

This is probably as simple as increasing pageInfoWindow.height. [1]
Abhinav, is this something you would like to work on?

[1] https://mxr.mozilla.org/mozilla-central/search?string=pageInfoWindow.height
Flags: needinfo?(abhinav.koppula)
Flags: firefox-backlog+
Can I work on this? I'm new on Bugzilla.
I'm able to reproduce it on my Win 10 machine.
Yes, you may work on it. We usually wait until a patch is attached to the bug before we assign the bug to new contributors.
Flags: needinfo?(abhinav.koppula)
I tried changing the value of pageInfoWindow.height in  /browser/ locales/ en-US/ chrome/ browser/ pageInfo.dtd . I also tried replacing height="&pageInfoWindow.height;" in /browser/base/content/pageinfo/pageInfo.xul with an actual value but that didn't help too. Can you suggest something else that I can try?
Flags: needinfo?(jaws)
Did you make sure that you are using a new profile? The window height may have been cached from adjusting the window previous to testing your patch.
Flags: needinfo?(jaws)
Yes. I tried it after removing the persist tag.
IIRC, removing the persist attribute doesn't remove the saved value. Please test with a new profile.
Changed PageInfoWindow.height to 550 to fit the contents. Turns out that the height was actually being cached. Creating a new profile did the trick.
Attachment #8658801 - Flags: review?(gavin.sharp)
Attachment #8658801 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → nanonikhil
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/90bde4f0eb4d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Depends on: 1235184
You need to log in before you can comment on or make changes to this bug.