1189574 - Clarify wording on publishing review requests

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Gregory Szorc [:gps]]

The wording for publishing review requests at push time makes a few references to "review request." There are always at least 2 review requests present. It isn't clear that publishing impacts the entire set/series. I just witnessed someone IRL get confused by this wording.

Comment 1

[Gregory Szorc [:gps]]

I'll take this low hanging fruit.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: change wording around review publishing (bug 1189574); r?mcote

reviewboard: change wording around review publishing (bug 1189574); r?mcote

"review series" is more appropriate since in the context of publishing
because "review request" implies a single thing, when we just printed
a list of multiple review requests.

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 8646604 [details]
MozReview Request: reviewboard: change wording around review publishing (bug 1189574); r?mcote

https://reviewboard.mozilla.org/r/15803/#review14189

I feel a little pedantic here, but I guess that's what this bug is about. :)  Changing "review request" to "review series" is now conflating "review requests" with "reviews", which we're also trying to be clear about.  Maybe "review request series"? ("review-request series" might actually be more grammatically correct, but I don't think it's necessary here.)

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8646604 [details]
MozReview Request: reviewboard: change wording around review publishing (bug 1189574); r?mcote

reviewboard: change wording around review publishing (bug 1189574); r?mcote

"review series" is more appropriate since in the context of publishing
because "review request" implies a single thing, when we just printed
a list of multiple review requests.

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8646604 [details]
MozReview Request: reviewboard: change wording around review publishing (bug 1189574); r?mcote

https://reviewboard.mozilla.org/r/15803/#review15289

::: hgext/reviewboard/client.py:658
(Diff revision 2)
> -            ui.status(_('(published review request %s)\n') % v)
> +            ui.status(_('(published review series %s)\n') % v)
>          elif k == 'error':
>              errored = True
>              rrid, error = v.split(' ', 1)
> -            ui.warn(_('error publishing review request %s: %s\n') %
> +            ui.warn(_('error publishing review series %s: %s\n') %

Looks like you missed these two.

::: hgext/reviewboard/tests/test-specify-reviewers.t:206
(Diff revision 2)
> -  (published review request 1)
> +  (published review series 1)

This'll need to be fixed too.

::: hgext/reviewboard/tests/test-specify-reviewers.t:287
(Diff revision 2)
> -  (published review request 1)
> +  (published review series 1)

And here.

::: hgext/reviewboard/tests/test-specify-reviewers.t:349
(Diff revision 2)
> -  (published review request 1)
> +  (published review series 1)

Ditto.

::: hgext/reviewboard/tests/test-specify-reviewers.t:415
(Diff revision 2)
> -  (published review request 1)
> +  (published review series 1)

Une autre.

::: hgext/reviewboard/tests/test-specify-reviewers.t:479
(Diff revision 2)
> -  (published review request 1)
> +  (published review series 1)

Encore.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8646604 [details]
MozReview Request: reviewboard: change wording around review publishing (bug 1189574); r?mcote

reviewboard: change wording around review publishing (bug 1189574); r?mcote

"review series" is more appropriate since in the context of publishing
because "review request" implies a single thing, when we just printed
a list of multiple review requests.

Comment 7

[Mark Côté [:mcote]]

Comment on attachment 8646604 [details]
MozReview Request: reviewboard: change wording around review publishing (bug 1189574); r?mcote

https://reviewboard.mozilla.org/r/15803/#review15415

Ship It!

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/d588b602f3e0faae03933f9f2cab30f0b6265dfa
reviewboard: change wording around review publishing (bug 1189574); r=mcote