1189575 - Old reviewboard extension not detected when pushing to autoreview repo

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Gregory Szorc [:gps]]

I just watched someone attempt to push to the autoreview repository with an out of date version-control-tools checkout and reviewboard client extension. The client attempted to upload all 250,000 mozilla-central commits to the autoreview repo. I had this user hit ctrl+c before it completed (it would have failed on a hook on the auto review repo).

We should see if there is a better way to detect ancient clients pushing to the autoreview repo that doesn't involve them wasting time uploading lots of data.

Comment 1

[Gregory Szorc [:gps]]

We can probably have the "unbundle" wire protocol command fail fast on auto discovery repos.

I hit this again today as part of pushing via HTTP. So I'm gonna see about fixing this real quick.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: disallow pushing and pull discovery repos (bug 1189575); r?smacleod

reviewboard: disallow pushing and pull discovery repos (bug 1189575); r?smacleod

Attempting to push to a discovery repository without the reviewboard
client extension installed results in a really bad experience. The
Mercurial client will see the discovery repo as if its a normal
Mercurial repository (no problem with that). However, it will then see
it is empty and attempt to upload all local changesets to it. This
wouldn't be bad except Mercurial first bundles all changesets to a
temporary local file then uploads the bundle in full before the server
applies it. You can imagine what this is like on mozilla-central :/

This patch short circuits the "heads" wire protocol command on discovery
repos. This command is called as part of changeset discovery so clients
know what to send and receive from the server. By making it error, we
quickly fail all push and pull operations. We print an actionable error
message so people can rectify the problem by installing the appropriate
Mercurial extension.

Comment 3

[Steven MacLeod [:smacleod]]

Comment on attachment 8671055 [details]
MozReview Request: reviewboard: disallow pushing and pull discovery repos (bug 1189575); r?smacleod

https://reviewboard.mozilla.org/r/21505/#review19701

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/a72ea86b3a1270c5a442804c8e823de3c5bafed7
reviewboard: disallow pushing and pulling discovery repos (bug 1189575); r=smacleod

Comment 5

[Gregory Szorc [:gps]]

This is deployed.