Closed
Bug 1189579
Opened 11 years ago
Closed 11 years ago
The preferences pane needs to be right aligned in RTL mode
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: ehsan.akhgari, Unassigned)
Details
(Keywords: rtl)
Attachments
(2 files)
|
502.82 KB,
image/png
|
Details | |
|
1.02 KB,
patch
|
jaws
:
review-
|
Details | Diff | Splinter Review |
See the screenshot for what it currently looks like...
| Reporter | ||
Comment 1•11 years ago
|
||
| Reporter | ||
Updated•11 years ago
|
Attachment #8641421 -
Flags: review?(jaws)
Comment 2•11 years ago
|
||
Comment on attachment 8641421 [details] [diff] [review]
Fix the direction of the prefpane on the in-content preferences window in RTL mode
Review of attachment 8641421 [details] [diff] [review]:
-----------------------------------------------------------------
I don't see the same issue with Hebrew locale on Firefox beta 40, http://screencast.com/t/DUwIi9OCsAH. Going to retest on Arabic build.
Comment 3•11 years ago
|
||
Arabic looks fine as well, http://screencast.com/t/6AFBrLHd
Comment 4•11 years ago
|
||
Comment on attachment 8641421 [details] [diff] [review]
Fix the direction of the prefpane on the in-content preferences window in RTL mode
Review of attachment 8641421 [details] [diff] [review]:
-----------------------------------------------------------------
Persian looks fine too. I'm not sure why you're seeing the gap between the pref pane and the categories. I tested all three of these locales on clean profiles.
Attachment #8641421 -
Flags: review?(jaws) → review-
Comment 5•11 years ago
|
||
Persian screenshot, http://screencast.com/t/DmcUACJh
| Reporter | ||
Comment 6•11 years ago
|
||
Hmm, how large was the browser window in these screenshots? If you look carefully at attachment 8641398 [details], the browser window needs to be large enough to make it apparent that the prefpane is left aligned.
Flags: needinfo?(jaws)
Comment 7•11 years ago
|
||
This is with the Persian locale browser window maximized, http://screencast.com/t/evluPThtZh
Flags: needinfo?(jaws)
| Reporter | ||
Comment 8•11 years ago
|
||
Hmm, testing Firefox Persian 40 beta, this bug is somehow gone... I guess something has fixed it in the mean time but I'm not sure what.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•