1189581 - Make service-workers/service-worker/fetch-cors-xhr.https.html pass

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Josh Matthews [:jdm]]

Dumping ground for changes necessary to make this test pass.

Comment 1

[Josh Matthews [:jdm]]

Attachment: WIP changes to make the test execute

Comment 2

[(no longer active)]

Attachment: Make service-workers/service-worker/fetch-cors-xhr.https.html pass

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8676244 [details] [diff] [review]
Make service-workers/service-worker/fetch-cors-xhr.https.html pass

Review of attachment 8676244 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html
@@ +150,5 @@
>        [
>          url + '?mode=cors&url=' +
>          encodeURIComponent(remote_url + '?ACAOrigin=' +
> +                           host_info['HTTPS_ORIGIN']),
> +        true, FAIL

I actually saw someone on IRC asking about this bug in chrome.  They are not setting RequestCredentials correctly on the FetchEvent.request.

Comment 4

[(no longer active)]

Interesting!  Their tests were similarly broken for CORS tainting as well.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07d5679826c9

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This broke the test: https://treeherder.mozilla.org/logviewer.html#?job_id=15969393&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b5821cd1783d

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df12438d4091

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Back out again for w(8) failures: https://treeherder.mozilla.org/logviewer.html#?job_id=15984903&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7e6d2a69f8c

Comment 9

[(no longer active)]

This time's gonna be the charm!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2eed6c293c

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5d2eed6c293c