Closed Bug 1189581 Opened 4 years ago Closed 4 years ago

Make service-workers/service-worker/fetch-cors-xhr.https.html pass

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox42 --- affected
firefox44 --- fixed

People

(Reporter: jdm, Assigned: ehsan)

References

Details

Attachments

(2 files)

Dumping ground for changes necessary to make this test pass.
Assignee: nobody → josh
Status: NEW → ASSIGNED
Blocks: 1180622
No longer blocks: 1189023
Assignee: josh → ehsan
Comment on attachment 8676244 [details] [diff] [review]
Make service-workers/service-worker/fetch-cors-xhr.https.html pass

Review of attachment 8676244 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html
@@ +150,5 @@
>        [
>          url + '?mode=cors&url=' +
>          encodeURIComponent(remote_url + '?ACAOrigin=' +
> +                           host_info['HTTPS_ORIGIN']),
> +        true, FAIL

I actually saw someone on IRC asking about this bug in chrome.  They are not setting RequestCredentials correctly on the FetchEvent.request.
Attachment #8676244 - Flags: review?(bkelly) → review+
Interesting!  Their tests were similarly broken for CORS tainting as well.
Flags: needinfo?(ehsan)
This time's gonna be the charm!
Flags: needinfo?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/5d2eed6c293c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.