Closed Bug 1189584 Opened 5 years ago Closed 4 years ago

[Nexus 5] Add support for the blobfree build

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hobinjk, Assigned: hobinjk)

References

Details

Attachments

(2 files)

56 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
56 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
Like bug 1172912, add the support into gonk-misc/Android.mk and the Nexus 5's device.mk.
This depends on bug 1189583 for the support of mkbootimg args in cmdline_fs.txt
Depends on: 1189583
Attached file device-hammerhead PR
Attachment #8650768 - Flags: review?(lissyx+mozillians)
NB: When running this on a Nexus 5 that previously had a rootless production build of Android installed, I found that I had to remove b2g-installer's summonRoot statements. It appears that b2g-installer does not actually need adb to be root at all (tested on Nexus 5 and Flame).
Assignee: nobody → hobinjk
Thanks James! Did you get a booting device after? Can we have PR for L port also?
Flags: needinfo?(hobinjk)
(In reply to [OFF 20/08-26/08] Alexandre LISSY :gerard-majax from comment #4)
> Thanks James! Did you get a booting device after? Can we have PR for L port
> also?

Yes, the device booted without error. I will work on the L port today.
Flags: needinfo?(hobinjk)
This is the PR based on the L branch. It works flawlessly. I also tested it installing on top of a phone running Cyanogenmod, where it also performed as expected.
Attachment #8651228 - Flags: review?(lissyx+mozillians)
Comment on attachment 8651228 [details] [review]
device-hammerhead PR for Nexus 5 L

Looks okay but please change the build id
Flags: needinfo?(hobinjk)
Attachment #8651228 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8650768 [details] [review]
device-hammerhead PR

Good!
Attachment #8650768 - Flags: review?(lissyx+mozillians) → review+
https://github.com/mozilla-b2g/device-hammerhead/commit/31b5bafd0d234984f1133a3b3d08839521f2b718
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1206412
This is resolved, clearing needinfo.
Flags: needinfo?(hobinjk)
You need to log in before you can comment on or make changes to this bug.