Closed Bug 1189630 Opened 9 years ago Closed 9 years ago

browser_translation_exceptions.js does not wait for the infobar to finish animating

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file, 1 obsolete file)

Make browser_translation_exceptions.js wait for infobar to finish animating
5.54 KB, patch
florian
: review+
Details | Diff | Splinter Review 
I'm filing this for the issue described in bug 1180125 comment 45. Basically, https://hg.mozilla.org/mozilla-central/rev/0e9d11e5302a from bug 994117 is disabled for GTK and that appears to be causing test failures.
Summary: popupshown event does not wait for transition on Linux → popupshown event does not wait for transitions on Linux
Attached patch Patch (obsolete) — — Splinter Review 
I haven't yet proven that this fixes the problem or that it doesn't create other problems but it's nearly the weekend here so I thought I'd put it up for review now so I can land it on Monday if it proves correct.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c651c1f6e930

I'll trigger another one later covering more tests.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Attachment #8641523 - Flags: review?(enndeakin)
(In reply to Brian Birtles (:birtles) from comment #1)
> I'll trigger another one later covering more tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc9ed4cc02f3
Comment on attachment 8641523 [details] [diff] [review]
Patch

This is disabled on Linux due to graphical issues.

I explained more about the real issue in bug 1180125.
Attachment #8641523 - Flags: review?(enndeakin) → review-
See bug 1180125 comment 53
Summary: popupshown event does not wait for transitions on Linux → browser_translation_exceptions.js does not wait for the infobar to finish animating
Attachment #8641523 - Attachment is obsolete: true
Attachment #8642253 - Flags: review?(enndeakin)
Comment on attachment 8642253 [details] [diff] [review]
Make browser_translation_exceptions.js wait for infobar to finish animating

Looks ok, but I think it would be better to get a review from someone familiar with this component.
Attachment #8642253 - Flags: review?(enndeakin)
Attachment #8642253 - Flags: review?(florian)
Attachment #8642253 - Flags: review?(florian) → review+
https://hg.mozilla.org/mozilla-central/rev/a01bf3016c08
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: