remove spdy specific telemetry and cwnd cookie

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

(Whiteboard: [spdy])

Attachments

(1 attachment)

Assignee

Description

4 years ago
as we start to transition to h2, remove telemetry that is spdy specific and remove the persistent cwnd settings that only google.com made use of (they are now on h2)
Assignee

Comment 1

4 years ago
Posted patch patch 1Splinter Review
Attachment #8641559 - Flags: review?(hurley)

Comment 2

4 years ago
Comment on attachment 8641559 [details] [diff] [review]
patch 1

Review of attachment 8641559 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/SpdySession31.cpp
@@ +1430,5 @@
>      LOG3(("Settings ID %d, Flags %X, Value %d", id, flags, value));
>  
>      switch (id)
>      {
>      case SETTINGS_TYPE_UPLOAD_BW:

Get rid of this (and the rest of the now-empty cases)

::: toolkit/components/telemetry/Histograms.json
@@ +1508,5 @@
>      "kind": "exponential",
>      "high": "1000",
>      "n_buckets": 50,
>      "extended_statistics_ok": true,
> +    "description": "h2: Settings Initial Window (rounded to KB)"

nit: caps H2 like you did above (or lower the other, or not :P)
Attachment #8641559 - Flags: review?(hurley) → review+
https://hg.mozilla.org/mozilla-central/rev/e293bbf8223c
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.