1189661 - "Harness status: Timeout" when running "waiting.https.html" test

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Noemí Freire (:noemi)]

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/waiting.https.html|


Harness status: Timeout
Found 1 tests
1 Timeout
* waiting is set -> timed out
Traces: https://pastebin.mozilla.org/8838602

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1189661 - either of active or waiting can be valid. r?bkelly

Bug 1189661 - either of active or waiting can be valid. r?bkelly

Comment 2

[Noemí Freire (:noemi)]

Patch provided by Nikhil so assigning this bug to him. Please feel free to change it if needed. Thanks!

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

https://reviewboard.mozilla.org/r/16875/#review15129

::: testing/web-platform/mozilla/tests/service-workers/service-worker/waiting.https.html:31
(Diff revision 1)
> +        var w = registration.waiting || registration.active;

As far as I can tell, the only way this should happen is if skipWaiting() has been called.  Note, the frame was loaded before registering the service worker here.  Can you explain how the spec allows going to active here?  I don't see it.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8651241 [details]
MozReview Request: Bug 1189661 - either of active or waiting can be valid. r?bkelly

Oh, I see now.  Its step 26 here:

  https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm

If there are no windows actively using that registration then it goes executes Activate immediately after Install.  Since the frame was existing before the registration its not "using" the registration yet.

Sorry for my confusion. Thanks! r=me

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

https://reviewboard.mozilla.org/r/16875/#review15139

::: testing/web-platform/mozilla/tests/service-workers/service-worker/waiting.https.html:30
(Diff revision 1)
> -        assert_equals(registration.waiting.scriptURL, normalizeURL(url));
> +        // immediately.

Maybe update this comment to reference step 26 of the Install algorithm.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

https://reviewboard.mozilla.org/r/16875/#review15145

::: testing/web-platform/mozilla/tests/service-workers/service-worker/waiting.https.html:36
(Diff revision 1)
>          // Should the existing frame ("frame") block activation?

Remove the comment about "should the existing frame block activiation".  I think we have determined the answer is "no".

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

https://reviewboard.mozilla.org/r/16877/#review15147

Ship It!

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a9d5366288ffde4ef60d33fc7d0d55c0a965a247
changeset:  a9d5366288ffde4ef60d33fc7d0d55c0a965a247
user:       Nikhil Marathe <[e-mail]>
date:       Fri Aug 21 14:25:46 2015 -0700
description:
Bug 1189661 - either of active or waiting can be valid. r=bkelly

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/696463139720ced7c255e1fbab8ae350f5063aa6
changeset:  696463139720ced7c255e1fbab8ae350f5063aa6
user:       Nikhil Marathe <[e-mail]>
date:       Mon Aug 24 13:59:46 2015 -0700
description:
Bug 1189661 - Update wpt expectation data. a=bustage.

CLOSED TREE

Comment 10

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7a370b605df608a689bea1a4be662e2cc4cd5ad7
changeset:  7a370b605df608a689bea1a4be662e2cc4cd5ad7
user:       Nikhil Marathe <[e-mail]>
date:       Mon Aug 24 14:43:16 2015 -0700
description:
Bug 1189661 - either of active or waiting can be valid. r=bkelly

Update wpt expectation data.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a370b605df6

Comment 12

[Noemí Freire (:noemi)]

Hi,

just checked on m-c (c46370eea81a revision) and the test successfully runs. Thanks for fixing it!

Summary

Harness status: OK

Found 1 tests
1 Pass
Details
Result	Test Name
Pass	waiting or active is set