Take a fast shortcut when searching for BreakpointActors and the map is empty

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 42

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Created attachment 8641567 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8641567 - Flags: review?(ttromey)
Created attachment 8641574 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty
Attachment #8641567 - Attachment is obsolete: true
Attachment #8641567 - Flags: review?(ttromey)
Attachment #8641574 - Flags: review?(ttromey)
I remember removing this code because it seemed like a pointless micro-optimization. I am amazed that it actually makes so big a difference. Any theories as to why?
My theory is that generators are very slow... I think they still don't even make it into Ion.

But yeah, not really sure what was up but this saved a couple hundred ms of jank.
Created attachment 8641772 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty
Attachment #8641574 - Attachment is obsolete: true
Attachment #8641574 - Flags: review?(ttromey)
Comment on attachment 8641772 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05a51b25a9c4
Attachment #8641772 - Flags: review?(jsantell)
Comment on attachment 8641772 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty

Review of attachment 8641772 [details] [diff] [review]:
-----------------------------------------------------------------

Very surprising, very nice
Attachment #8641772 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/de94f408a901
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.