1189664 - Take a fast shortcut when searching for BreakpointActors and the map is empty

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Take a fast shortcut when searching for BreakpointActors and the map is empty

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Take a fast shortcut when searching for BreakpointActors and the map is empty

Comment 3

[Eddy Bruel [:ejpbruel]]

I remember removing this code because it seemed like a pointless micro-optimization. I am amazed that it actually makes so big a difference. Any theories as to why?

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

My theory is that generators are very slow... I think they still don't even make it into Ion.

But yeah, not really sure what was up but this saved a couple hundred ms of jank.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Take a fast shortcut when searching for BreakpointActors and the map is empty

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8641772 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05a51b25a9c4

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8641772 [details] [diff] [review]
Take a fast shortcut when searching for BreakpointActors and the map is empty

Review of attachment 8641772 [details] [diff] [review]:
-----------------------------------------------------------------

Very surprising, very nice

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/de94f408a901

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de94f408a901